refactor: introduce cache for members list fetched by ZE #2331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ap891843
force-pushed
the
feature/introduce_cache_for_member
branch
from
485ec93
to
5923a17
Compare
| @@ -132,7 +132,8 @@ describe("Tests Copybook download from DNS", () => { | |||
| "document-uri", | |||
| "DNS.PATH", | |||
| ); | |||
| expect(allMemberMock).toHaveBeenCalledWith("DNS.PATH"); | |||
| // cache resolves the members | |||
| expect(allMemberMock).not.toHaveBeenCalled(); | |||
There was a problem hiding this comment.
I'd suggest to make a new test (for datasets and uss), one verifies that the api is called, the other verifies usage of the cache.
ap891843
force-pushed
the
feature/introduce_cache_for_member
branch
from
5923a17
to
ce52efe
Compare
Signed-off-by: Aman Prashant <aman.prashant@broadcom.com>
ap891843
force-pushed
the
feature/introduce_cache_for_member
branch
from
ce52efe
to
524d1fa
Compare
slavek-kucera
approved these changes
Jun 11, 2024
ishche
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: