Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix cics assign command to take parameters in any order #2342

Merged

Conversation

ap891843
Copy link
Contributor

@ap891843 ap891843 commented Jun 17, 2024

fix cics assign command to take parameters in any order. This based on the documentation at https://www.ibm.com/docs/en/cics-ts/6.x?topic=summary-assign

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Check the newly added use-case test
            EXEC CICS
                ASSIGN
                SYSID        (WM-CICS-SYSID)
                MAPHEIGHT        (WM-CICS-SYSID)
                INVOKINGPROG (WM-INVOKING-PROGRAM)
                STARTCODE(WM-INVOKING-PROGRAM)
                TWALENG(WM-INVOKING-PROGRAM)
                MAJORVERSION(WM-INVOKING-PROGRAM)
           END-EXEC           .

Checklist:

  • Each of my commits contains one meaningful change
  • I have performed rebase of my branch on top of the development
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

fix cics assign command to take parameters in any order. This based on the documentation at https://www.ibm.com/docs/en/cics-ts/6.x?topic=summary-assign

Signed-off-by: Aman Prashant <aman.prashant@broadcom.com>
@ap891843 ap891843 changed the base branch from development to lsp-events-2 June 25, 2024 11:38
@ap891843 ap891843 changed the base branch from lsp-events-2 to development June 25, 2024 12:07
cics_assign: ASSIGN (ABCODE cics_data_area | ABDUMP cics_data_area | ABPROGRAM cics_data_area | ACTIVITY cics_data_area |
cics_assign: ASSIGN (cics_assign_parameter1 | cics_assign_parameter2) *;

cics_assign_parameter1: ABCODE cics_data_area | ABDUMP cics_data_area | ABPROGRAM cics_data_area | ACTIVITY cics_data_area |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the reason for having two rules here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just to mimic the grammar flow from the documentation https://www.ibm.com/docs/en/cics-ts/6.x?topic=summary-assign

@ap891843 ap891843 merged commit 4767165 into eclipse-che4z:development Jul 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants