Feature/e4e/flag #2344
Feature/e4e/flag #2344
Conversation
clients/cobol-lsp-vscode-extension/src/services/copybook/CopybookMessageHandler.ts
Outdated
Show resolved
Hide resolved
clients/cobol-lsp-vscode-extension/src/services/copybook/CopybookDownloadService.ts
Outdated
Show resolved
Hide resolved
| "ENDEVOR_PROCESSOR" | ||
| ], | ||
| "enumDescriptions": [ | ||
| "ZOWE paths to retrieve copybooks", |
There was a problem hiding this comment.
"Zowe paths" is not terminology we use anywhere in the app or documentation so I wouldn't recommend using it here.
I would make the two options:
COBOL LS
ENDEVOR
enumDescriptions:
Retrieve copybooks from mainframe data sets and USS files specified in the COBOL Language Support extension settings.
Retrieve copybooks from locations specified in the Endevor element processor group.
There was a problem hiding this comment.
I agree that the description could be better. Still the two options should stay as
- ZOWE
- ENDEVOR_PROCESSOR
because in the first case ZOWE Explorer is used to retrieve the copybooks and in the second case Explorer for Endevor is used.
Soon we will have a third option ENDEVOR_ACMQ which will differ from ENDEVOR_PROCESSOR in the sense that the source of configuration will not be a processor, but an ACMQ query. In both cases Explorer for Endevor will be used for the download.
The suggested enumDescriptions:
- Use Zowe Explorer to retrieve copybooks from mainframe data sets and USS files specified in the COBOL Language Support extension settings.
- Use Explorer for Endevor to retrieve copybooks from locations specified in the Endevor element processor group.
What do you think @zeibura ?
There was a problem hiding this comment.
Zowe Explorer doesnt have Zowe in all caps, but otherwise fine
| "ZOWE paths to retrieve copybooks", | ||
| "ENDEVOR_PROCESSOR to retrieve copybooks" | ||
| ], | ||
| "description": "The method that is used to retrieve copybooks for elements open via Explorer for Endevor.", |
There was a problem hiding this comment.
"description": "The method that is used to retrieve remote copybooks for elements opened in Explorer for Endevor."
Co-authored-by: slavek-kucera <53339291+slavek-kucera@users.noreply.github.com>
How Has This Been Tested?
Default value of cobol-lsp.cpy-manager.endevor-dependencies should fetch existing paths from zowe.
Changing cobol-lsp.cpy-manager.endevor-dependencies to ENDEVOR_PROCESSOR leads downloading relevant copybooks from endevor
Checklist: