Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix incorrect conditions in tests #2351

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

slavek-kucera
Copy link
Contributor

No description provided.

@slavek-kucera slavek-kucera marked this pull request as ready for review June 25, 2024 07:35
@VitGottwald VitGottwald requested review from ap891843 and removed request for ap891843 June 25, 2024 07:59
Copy link
Contributor

@VitGottwald VitGottwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As a followup we should make sure that the tests actually fail when incorrect conditions are specified.

@slavek-kucera slavek-kucera merged commit 343d3a8 into development Jun 26, 2024
17 checks passed
@slavek-kucera slavek-kucera deleted the test_int_bugs branch June 26, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants