Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML data host and file reference variables #2365

Conversation

ilidio-lopes
Copy link
Contributor

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Check the test cases in the PR . XML data host variables can be in a sample code
        Identification Division.
        Program-Id. 'TEST1'.
        Data Division.
         Working-Storage Section.
       01 VAR3 USAGE IS SQL TYPE IS XML AS CHARACTER LARGE OBJECT (10 M).
       01 VAR-NAME4 USAGE IS SQL TYPE IS XML AS CHAR LARGE OBJECT (10 G).
       01  VAR-NAME5 USAGE IS SQL TYPE IS XML AS CLOB (20)
       01  VAR-NAME6 USAGE IS SQL TYPE IS XML AS DBCLOB (30 K)
       01  VAR-NAME7 USAGE IS SQL TYPE IS XML AS BLOB-LOCATOR.
       01  VAR-NAME8 USAGE IS SQL TYPE IS XML AS CLOB-LOCATOR.
        PROCEDURE division

image

  • Test A
  • Test B

Checklist:

  • Each of my commits contains one meaningful change
  • I have performed rebase of my branch on top of the development
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@Nurkambay
Copy link
Contributor

@ilidio-lopes please resolve conflicts

@ilidio-lopes ilidio-lopes force-pushed the US966849-XML_data_host_and_file_reference_variables1 branch 2 times, most recently from 001adea to 7cc2097 Compare July 17, 2024 14:07
@ap891843
Copy link
Contributor

ap891843 commented Jul 17, 2024

I suggest rebase with development. Can see 2 unnecessary commits bdc1080 and 5890e35
rest LGTM

Copy link
Contributor

@ap891843 ap891843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. add a use case for level 2-48 and a level 49 with error
  2. Two unnecessary commits bdc1080 and 5890e35

@ilidio-lopes ilidio-lopes force-pushed the US966849-XML_data_host_and_file_reference_variables1 branch from 7cc2097 to 5f1abc1 Compare July 17, 2024 14:48
@ilidio-lopes ilidio-lopes force-pushed the US966849-XML_data_host_and_file_reference_variables1 branch from 0398dbb to f4023f1 Compare July 18, 2024 09:37
@Nurkambay Nurkambay requested a review from ap891843 July 18, 2024 14:40
@ap891843 ap891843 merged commit a99147e into eclipse-che4z:development Jul 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants