Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix implicit dialect node position #2369

Merged
merged 2 commits into from
Jul 3, 2024
Merged

fix: Fix implicit dialect node position #2369

merged 2 commits into from
Jul 3, 2024

Conversation

Nurkambay
Copy link
Contributor

Checklist:

  • Each of my commits contains one meaningful change
  • I have performed rebase of my branch on top of the development
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@Nurkambay Nurkambay requested review from ishche and ap891843 July 2, 2024 19:29
@Nurkambay Nurkambay changed the title fix: do not invalidate implicit copybook cache on re-analysis fix: Fix implicit dialect node position Jul 2, 2024
@Nurkambay Nurkambay marked this pull request as draft July 3, 2024 10:00
@Nurkambay Nurkambay marked this pull request as ready for review July 3, 2024 13:21
@Nurkambay Nurkambay merged commit c41c755 into eclipse-che4z:development Jul 3, 2024
17 checks passed
@Nurkambay Nurkambay deleted the fix-pos branch July 3, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishche ishche ishche approved these changes

@ap891843 ap891843 Awaiting requested review from ap891843

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nurkambay @ishche