Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Cli analysis improvements #2379

Merged

Conversation

mm-broadcom
Copy link
Contributor

Added:

  • Proper handling of error when processor groups does not exist
  • Made the copybook path argument optional for the CLI
  • Added a flag to suppress the diagnostics portion
  • Updated labels to be clearer
  • Added command to produce the extended source. (Can do so in the CLI or save it to a specified location)
  • Accept source from STDIN

How Has This Been Tested?

Tested the CLI locally as each change/feature was added.

Checklist:

  • Each of my commits contains one meaningful change
  • I have performed rebase of my branch on top of the development
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

Added IOException handling for Processors whether it is missing or had issues with reading.
Allow the user to run analysis without the copybook folder/extensions or the workspace folder being provided.
Add ability/flag to hide diagnostics and only print the URI, dialect/language, timings and garbage-collection/memory data.
Print Extended Source to terminal if flag is present
add ability to save extended source to a specified file/location.
@mm-broadcom
Copy link
Contributor Author

@VitGottwald Added the option to show/hide the diagnostics to the VSCode command.

@Nurkambay Nurkambay requested a review from ap891843 July 15, 2024 14:38
Refactored some of the code, added named constants for the return codes and cleaned up some exception handling code as requested on the PR.
@Nurkambay Nurkambay merged commit e83e997 into eclipse-che4z:development Jul 17, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants