-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Cli analysis improvements #2379
Merged
Nurkambay
merged 13 commits into
eclipse-che4z:development
from
mm-broadcom:cli-analysis-improvements
Jul 17, 2024
Merged
feat: Cli analysis improvements #2379
Nurkambay
merged 13 commits into
eclipse-che4z:development
from
mm-broadcom:cli-analysis-improvements
Jul 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added IOException handling for Processors whether it is missing or had issues with reading.
Allow the user to run analysis without the copybook folder/extensions or the workspace folder being provided.
Add ability/flag to hide diagnostics and only print the URI, dialect/language, timings and garbage-collection/memory data.
Print Extended Source to terminal if flag is present
add ability to save extended source to a specified file/location.
…adcom/che-che4z-lsp-for-cobol into cli-analysis-improvements
13 tasks
Add choice to show/hide diagnostics to the VSCode command.
@VitGottwald Added the option to show/hide the diagnostics to the VSCode command. |
Nurkambay
reviewed
Jul 15, 2024
server/engine/src/main/java/org/eclipse/lsp/cobol/cli/command/Cli.java
Outdated
Show resolved
Hide resolved
Nurkambay
reviewed
Jul 15, 2024
server/engine/src/main/java/org/eclipse/lsp/cobol/cli/command/CliAnalysis.java
Show resolved
Hide resolved
Nurkambay
reviewed
Jul 15, 2024
server/engine/src/main/java/org/eclipse/lsp/cobol/cli/command/ListCopybooks.java
Outdated
Show resolved
Hide resolved
Nurkambay
reviewed
Jul 15, 2024
server/engine/src/main/java/org/eclipse/lsp/cobol/cli/command/ListSources.java
Outdated
Show resolved
Hide resolved
Refactored some of the code, added named constants for the return codes and cleaned up some exception handling code as requested on the PR.
Nurkambay
reviewed
Jul 15, 2024
server/engine/src/main/java/org/eclipse/lsp/cobol/cli/command/CliAnalysis.java
Outdated
Show resolved
Hide resolved
Nurkambay
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
How Has This Been Tested?
Tested the CLI locally as each change/feature was added.
Checklist: