Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/hover copybook #2381

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Conversation

ap891843
Copy link
Contributor

@ap891843 ap891843 commented Jul 12, 2024

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Hover over implicit copybooks should not throw error. Also, wont show any hover content. But if the copybook is explicitly provided, show the hover
  • Copybooks hover should work always ( currently if db2 implicit copybooks are added to a program, copybook hover doesn't work)

Checklist:

  • Each of my commits contains one meaningful change
  • I have performed rebase of my branch on top of the development
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@ap891843
Copy link
Contributor Author

@mm-broadcom @ilidio-lopes

Copy link
Contributor Author

@ap891843 ap891843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small refactor

@Nurkambay
Copy link
Contributor

@ap891843 I did not catch where is the actual fix. I see only the renaming of the method here

@ap891843 ap891843 merged commit 8bd8a71 into eclipse-che4z:development Jul 16, 2024
16 checks passed
ilidio-lopes pushed a commit to ilidio-lopes/che-che4z-lsp-for-cobol that referenced this pull request Jul 17, 2024
* fix: show hover for user supplied copybooks
ilidio-lopes pushed a commit to ilidio-lopes/che-che4z-lsp-for-cobol that referenced this pull request Jul 17, 2024
* fix: show hover for user supplied copybooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants