Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/dialect/copybooks #2387

Merged
merged 14 commits into from
Jul 25, 2024
Merged

Feature/dialect/copybooks #2387

merged 14 commits into from
Jul 25, 2024

Conversation

KutluOzel-b
Copy link
Contributor

Changed Copybook download request with dialects - copybook tuples

Checklist:

  • Each of my commits contains one meaningful change
  • I have performed rebase of my branch on top of the development
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@KutluOzel-b
Copy link
Contributor Author

@Nurkambay , @slavek-kucera , @ap891843 Please review

KutluOzel-b and others added 2 commits July 23, 2024 10:51
@KutluOzel-b @slavek-kucera
Update server/engine/src/main/java/org/eclipse/lsp/cobol/service/copy…
517ed34 
…books/CopybookServiceImpl.java

Co-authored-by: slavek-kucera <53339291+slavek-kucera@users.noreply.github.com>
@KutluOzel-b
comments
c28d793
@ap891843 ap891843 merged commit 86b8bb9 into eclipse-che4z:development Jul 25, 2024
17 checks passed
chacebot pushed a commit to chacebot/che-che4z-lsp-for-cobol that referenced this pull request Jul 26, 2024
@KutluOzel-b @slavek-kucera @chacebot
Feature/dialect/copybooks (eclipse-che4z#2387)
00acee5 
* draft impl

* change dto fields

* fix field names

* comments

* missed ones

* comment

* comments

* remove value class

* Update server/engine/src/main/java/org/eclipse/lsp/cobol/service/copybooks/CopybookServiceImpl.java

Co-authored-by: slavek-kucera <53339291+slavek-kucera@users.noreply.github.com>

* comments

---------

Co-authored-by: slavek-kucera <53339291+slavek-kucera@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavek-kucera slavek-kucera slavek-kucera approved these changes

@ap891843 ap891843 Awaiting requested review from ap891843

@Nurkambay Nurkambay Awaiting requested review from Nurkambay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KutluOzel-b @slavek-kucera @ap891843