Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Encoding error during copybook download #2402

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

slavek-kucera
Copy link
Contributor

fixes #2400

@slavek-kucera slavek-kucera marked this pull request as ready for review July 24, 2024 08:44
Copy link
Contributor

@VitGottwald VitGottwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested and works fine. No more error popups about encoding.

@slavek-kucera slavek-kucera merged commit 70eafd1 into development Jul 24, 2024
17 checks passed
@slavek-kucera slavek-kucera deleted the fix_download_issue branch July 24, 2024 11:26
mm-broadcom pushed a commit to mm-broadcom/che-che4z-lsp-for-cobol that referenced this pull request Jul 24, 2024
ap891843 pushed a commit that referenced this pull request Jul 24, 2024
* Add grammar for Binary Host Variable Arrays

Add grammar for Binary Host Variable Arrays. (New branch due to the old one getting out of date and merges/updates caused it to break.)

* Fixed error and added unit tests

Fixed error and added unit tests.

* Added missing override due to merge

* Fixed error and added unit tests

Fixed error and added unit tests.

* Remove dots (#2399)

chore: remove dits

* fix: Encoding error during copybook download (#2402)

* Fixed compile issue from rebase.

* Add OCCURS to SQL.tmlLanguage.json

Add OCCURS to SQL.tmlLanguage.json to provide highlighting.

---------

Co-authored-by: Vit Gottwald <vit.gottwald@broadcom.com>
Co-authored-by: slavek-kucera <53339291+slavek-kucera@users.noreply.github.com>
chacebot pushed a commit to chacebot/che-che4z-lsp-for-cobol that referenced this pull request Jul 26, 2024
* Add grammar for Binary Host Variable Arrays

Add grammar for Binary Host Variable Arrays. (New branch due to the old one getting out of date and merges/updates caused it to break.)

* Fixed error and added unit tests

Fixed error and added unit tests.

* Added missing override due to merge

* Fixed error and added unit tests

Fixed error and added unit tests.

* Remove dots (eclipse-che4z#2399)

chore: remove dits

* fix: Encoding error during copybook download (eclipse-che4z#2402)

* Fixed compile issue from rebase.

* Add OCCURS to SQL.tmlLanguage.json

Add OCCURS to SQL.tmlLanguage.json to provide highlighting.

---------

Co-authored-by: Vit Gottwald <vit.gottwald@broadcom.com>
Co-authored-by: slavek-kucera <53339291+slavek-kucera@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting an encoding error during copybook download
3 participants