feat: XML host file reference variable array support #2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add grammar for Binary Host Variable Arrays. (New branch due to the old one getting out of date and merges/updates caused it to break.)
Fixed error and added unit tests.
Add grammar for Binary Host Variable Arrays. (New branch due to the old one getting out of date and merges/updates caused it to break.)
Fixed error and added unit tests.
Add OCCURS to SQL.tmlLanguage.json to provide highlighting.
Add the grammar needed to make the current XML variable rule into one that supports arrays as well.
slavek-kucera
requested changes
Jul 25, 2024
server/engine/src/test/java/org/eclipse/lsp/cobol/usecases/sql/TestSqlHostVariable.java
Show resolved
Hide resolved
server/engine/src/main/antlr4/org/eclipse/lsp/db2/parser/Db2SqlParser.g4
Show resolved
Hide resolved
Add Array implicit variable declaration handling
…e-Reference-Variable-Support-V2
Fixed tests due to generated variables.
server/engine/src/main/antlr4/org/eclipse/lsp/db2/parser/Db2SqlParser.g4
Outdated
Show resolved
Hide resolved
server/engine/src/test/java/org/eclipse/lsp/cobol/usecases/sql/TestSqlHostVariable.java
Show resolved
Hide resolved
…lParser.g4 Co-authored-by: slavek-kucera <53339291+slavek-kucera@users.noreply.github.com>
slavek-kucera
approved these changes
Jul 25, 2024
server/engine/src/test/java/org/eclipse/lsp/cobol/usecases/sql/TestSqlHostVariable.java
Show resolved
Hide resolved
…/github.com/mm-broadcom/che-che4z-lsp-for-cobol into XML-Host-File-Reference-Variable-Support-V2
ap891843
approved these changes
Jul 25, 2024
chacebot
pushed a commit
to chacebot/che-che4z-lsp-for-cobol
that referenced
this pull request
Jul 26, 2024
) * Add grammar for Binary Host Variable Arrays Add grammar for Binary Host Variable Arrays. (New branch due to the old one getting out of date and merges/updates caused it to break.) * Added missing override due to merge * Fixed error and added unit tests Fixed error and added unit tests. * Fixed compile issue from rebase. * Add grammar for Binary Host Variable Arrays Add grammar for Binary Host Variable Arrays. (New branch due to the old one getting out of date and merges/updates caused it to break.) * Fixed error and added unit tests Fixed error and added unit tests. * Add OCCURS to SQL.tmlLanguage.json Add OCCURS to SQL.tmlLanguage.json to provide highlighting. * Add array functionality to XML variable rule Add the grammar needed to make the current XML variable rule into one that supports arrays as well. * Added unit test * Add range unit tests * Add Array implicit variable declaration handling Add Array implicit variable declaration handling * Add test for generated variables. * Fixed tests due to generated variables. Fixed tests due to generated variables. * Update server/engine/src/main/antlr4/org/eclipse/lsp/db2/parser/Db2SqlParser.g4 Co-authored-by: slavek-kucera <53339291+slavek-kucera@users.noreply.github.com> * Added detail to a test --------- Co-authored-by: slavek-kucera <53339291+slavek-kucera@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the grammar to support XML host and file reference variable arrays per IBM's documentation: https://www.ibm.com/docs/en/db2-for-zos/13?topic=cobol-host-variable-arrays-in#db2z_hostvariablearraycobol__title__20
How Has This Been Tested?
Verified in VS Code with a sample program/setup and also made some unit tests as well.
Checklist: