Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix dimension validation of lob_xml_host_variables #2411

Merged
merged 1 commit into from
Jul 31, 2024
Merged

fix: fix dimension validation of lob_xml_host_variables #2411

merged 1 commit into from
Jul 31, 2024

Conversation

ap891843
Copy link
Contributor

@ap891843 ap891843 commented Jul 30, 2024 •
edited
Loading

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test analysis doesn't break for below code
        Identification Division.
        Program-Id. 'TEST1'.
        Data Division.
         Working-Storage Section.
       01 GREET.
          02 VA USAGE IS SQL TYPE IS XML AS CLOB (10) OCCURS 400 TIMES.
        PROCEDURE DIVISION.

Checklist:

  • Each of my commits contains one meaningful change
  • I have performed rebase of my branch on top of the development
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@ap891843
Copy link
Contributor Author

@mm-broadcom please review

@ap891843 ap891843 force-pushed the fix/lob_xml_host_variables_validation branch from 3476c7f to 8d5e5cc Compare July 30, 2024 15:03
@ap891843 ap891843 force-pushed the fix/lob_xml_host_variables_validation branch from df6b20e to 7677578 Compare July 31, 2024 08:11
@ap891843
fix: fix dimension validation of lob_xml_host_variables
10ede58 
Signed-off-by: ap891843 <aman.prashant@broadcom.com>
@ap891843 ap891843 force-pushed the fix/lob_xml_host_variables_validation branch from 7677578 to 10ede58 Compare July 31, 2024 08:47
@ap891843 ap891843 merged commit 6501db3 into eclipse-che4z:development Jul 31, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavek-kucera slavek-kucera slavek-kucera approved these changes

@ishche ishche Awaiting requested review from ishche

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ap891843 @slavek-kucera