Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avoid redundant rebuilds #2416

Merged
merged 2 commits into from
Aug 2, 2024
Merged

fix: Avoid redundant rebuilds #2416

merged 2 commits into from
Aug 2, 2024

Conversation

slavek-kucera
Copy link
Contributor

No description provided.

@slavek-kucera slavek-kucera marked this pull request as ready for review August 2, 2024 12:58
ap891843
ap891843 approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@ap891843 ap891843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !
I guess @ishche has more idea about the parser module and its intended use case.

@ishche
Copy link
Contributor

ishche commented Aug 2, 2024

Nope, let's merge it.

@slavek-kucera slavek-kucera merged commit 86da47a into development Aug 2, 2024
33 checks passed
@slavek-kucera slavek-kucera deleted the fix_redundant_rebuilds branch August 2, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ap891843 ap891843 ap891843 approved these changes

@ishche ishche Awaiting requested review from ishche

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slavek-kucera @ishche @ap891843