Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check string quote semantics on extended document #2421

Merged

Conversation

ap891843
Copy link
Contributor

@ap891843 ap891843 commented Aug 5, 2024

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test below code works without diagnostics
       IDENTIFICATION DIVISION.
       PROGRAM-ID. testabb.
       ENVIRONMENT DIVISION.
       CONFIGURATION SECTION.
       SPECIAL-NAMES.
       INPUT-OUTPUT SECTION.
       FILE-CONTROL.
       DATA DIVISION.
        FILE SECTION.
        WORKING-STORAGE SECTION.
       01 WS-COND-UPD pic x(232).
       01 RANDOMV pic x(2).
       PROCEDURE DIVISION.
           display 'tetsing....'
                 IF WS-COND-UPD = SPACES OR '= ' OR      
              '< ' OR '> ' OR '¬=' OR '<=' OR '>=' OR "P'" OR       
              "T'" OR "C'" OR "N'" OR "X'"                          
            MOVE 'Y' TO RANDOMV    
           END-IF  . 
       IDENTIFICATION DIVISION.
       PROGRAM-ID. testas.
       ENVIRONMENT DIVISION.
       CONFIGURATION SECTION.
       SPECIAL-NAMES.
       INPUT-OUTPUT SECTION.
       FILE-CONTROL.
       DATA DIVISION.
        FILE SECTION.
        WORKING-STORAGE SECTION.
       01  FILLER  PIC  X(62) VALUE                                     
           '  then it must be either ''CLOSE'', ''NOCLOSE'', ''ENHANCED'
      -    '''.    
        LINKAGE SECTION.
       PROCEDURE DIVISION.

Checklist:

  • Each of my commits contains one meaningful change
  • I have performed rebase of my branch on top of the development
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@ap891843 ap891843 marked this pull request as draft August 6, 2024 10:17
Signed-off-by: ap891843 <aman.prashant@broadcom.com>
Signed-off-by: ap891843 <aman.prashant@broadcom.com>
@ap891843 ap891843 marked this pull request as ready for review August 6, 2024 11:22
@Nurkambay Nurkambay merged commit cd11624 into eclipse-che4z:development Aug 8, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants