-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/bump version #2428
Chore/bump version #2428
Conversation
55cebed
to
60dd1d3
Compare
60dd1d3
to
85b543d
Compare
Signed-off-by: ap891843 <aman.prashant@broadcom.com>
Signed-off-by: ap891843 <aman.prashant@broadcom.com>
Signed-off-by: ap891843 <aman.prashant@broadcom.com>
85b543d
to
f342c0f
Compare
Signed-off-by: ap891843 <aman.prashant@broadcom.com>
Signed-off-by: ap891843 <aman.prashant@broadcom.com>
Signed-off-by: ap891843 <aman.prashant@broadcom.com>
"glob": "10.3.10", | ||
"iconv-lite": "^0.6.3", | ||
"micromatch": "^4.0.7", | ||
"vscode-languageclient": "8.0.2" | ||
"vscode-languageclient": "^8.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Is this safe? would this lead to any backward in compatibility for some users ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we will not face with a situation when backend is old and frontend is new. So far we do not have any such customers who are using our code to create their own extensions, so I think we are safe
<maven.antlr4.plugin.version>4.7</maven.antlr4.plugin.version> | ||
<antlr.version>4.7.1</antlr.version> | ||
<maven.antlr4.plugin.version>4.13.2</maven.antlr4.plugin.version> | ||
<antlr.version>4.13.2</antlr.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Why do we need to update the versions in other extensions?
coz, of the usecase tests. The generated usecaseTestLexer expects the version to be 4.13.2
static { RuntimeMetaData.checkVersion("4.13.2", RuntimeMetaData.VERSION); }
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: