Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/bump version #2428

Merged
merged 6 commits into from
Aug 15, 2024
Merged

Conversation

ap891843
Copy link
Contributor

@ap891843 ap891843 commented Aug 9, 2024

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test no regression introduced

Checklist:

  • Each of my commits contains one meaningful change
  • I have performed rebase of my branch on top of the development
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@ap891843 ap891843 requested review from ishche and Nurkambay and removed request for ishche August 9, 2024 14:45
@ap891843 ap891843 marked this pull request as draft August 12, 2024 08:52
Signed-off-by: ap891843 <aman.prashant@broadcom.com>
Signed-off-by: ap891843 <aman.prashant@broadcom.com>
Signed-off-by: ap891843 <aman.prashant@broadcom.com>
Signed-off-by: ap891843 <aman.prashant@broadcom.com>
@ap891843 ap891843 marked this pull request as ready for review August 12, 2024 09:36
Signed-off-by: ap891843 <aman.prashant@broadcom.com>
Signed-off-by: ap891843 <aman.prashant@broadcom.com>
"glob": "10.3.10",
"iconv-lite": "^0.6.3",
"micromatch": "^4.0.7",
"vscode-languageclient": "8.0.2"
"vscode-languageclient": "^8.1.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Is this safe? would this lead to any backward in compatibility for some users ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we will not face with a situation when backend is old and frontend is new. So far we do not have any such customers who are using our code to create their own extensions, so I think we are safe

<maven.antlr4.plugin.version>4.7</maven.antlr4.plugin.version>
<antlr.version>4.7.1</antlr.version>
<maven.antlr4.plugin.version>4.13.2</maven.antlr4.plugin.version>
<antlr.version>4.13.2</antlr.version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Why do we need to update the versions in other extensions?

coz, of the usecase tests. The generated usecaseTestLexer expects the version to be 4.13.2

static { RuntimeMetaData.checkVersion("4.13.2", RuntimeMetaData.VERSION); }

@ap891843 ap891843 merged commit cd37c4c into eclipse-che4z:development Aug 15, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants