Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symbols are not recognized inside literals #193

Closed
genntt opened this issue Oct 10, 2021 · 3 comments · Fixed by #207
Closed

Symbols are not recognized inside literals #193

genntt opened this issue Oct 10, 2021 · 3 comments · Fixed by #207
Assignees
@slavek-kucera
Labels
enhancement New feature or request released on @release-1.0.0 released

Comments

@genntt
Copy link

genntt commented Oct 10, 2021 •
edited
Loading

Symbols are not recognized inside literals.
E.g., 'Find All References' to X issued in line 1 returns no result.

x

Platform

  • Editor: VS Code Version 1.61.0
  • OS: Microsoft Windows Version 10.0.19043.1237
  • Plugin version: HLASM Language Support v0.14.1
@slavek-kucera slavek-kucera added the enhancement New feature or request label Oct 11, 2021
@slavek-kucera
Copy link
Contributor

slavek-kucera commented Oct 11, 2021 •
edited
Loading

Hello @genntt, thank you for reporting the issue.

The literal support is currently incomplete and limited mostly to validation of syntax (#75).

@slavek-kucera slavek-kucera self-assigned this Nov 9, 2021
@slavek-kucera slavek-kucera linked a pull request Dec 1, 2021 that will close this issue
feat: Literal support #207
Merged
slavek-kucera added a commit that referenced this issue Dec 10, 2021
@slavek-kucera
feat: Literal support (#207)
44a93f2 
(closes #193, closes #75)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavek-kucera slavek-kucera

Labels
enhancement New feature or request released on @release-1.0.0 released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Literal support slavek-kucera/che-che4z-lsp-for-hlasm
2 participants
@slavek-kucera @genntt