Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ANLTR visitors from the code #60

Closed
4 tasks done
asmelko opened this issue Jun 11, 2020 · 0 comments · Fixed by #65
Closed
4 tasks done

Remove ANLTR visitors from the code #60

asmelko opened this issue Jun 11, 2020 · 0 comments · Fixed by #65
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@asmelko
Copy link
Contributor

asmelko commented Jun 11, 2020

Describe the solution you'd like
The current evaluation of conditional assembly expressions rely on ANTLR visitors. It is due to the fact that these expressions are stored as ANTLR ParsingRuleContext pointer.

However, this is not convenient because to preserve the validity of these pointers, we must not destroy ANTLR parser that created the pointers.

This restricts us in the further development of the plugin.

Acceptance criteria

  • Design and implement a new architecture for the CA expressions
  • Rewrite grammar rule actions to produce new architecture classes rather than ParsingRuleContext pointers
  • Refactor the source code that uses these pointers
  • Update wiki pages
@asmelko asmelko self-assigned this Jun 11, 2020
@asmelko asmelko added the enhancement New feature or request label Jun 11, 2020
@fox0r fox0r added this to the 0.12.0 milestone Jun 22, 2020
@asmelko asmelko linked a pull request Jul 16, 2020 that will close this issue
@asmelko asmelko closed this as completed Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants