Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Conditional assembly expressions #65

Merged
merged 107 commits into from
Aug 24, 2020
Merged

Conversation

asmelko
Copy link
Contributor

@asmelko asmelko commented Jul 10, 2020

Removed ANTLR visitors that used to evaluate expressions.
New tree of classes representing CA expressions was created.

@asmelko
Copy link
Contributor Author

asmelko commented Aug 17, 2020

Improved coverage a bit. Covered methods of ca_expr_list class and creation of all new diagnostics that are currently supported (some tests are commented out due to unimplemented features).

@asmelko asmelko requested a review from zeibura August 19, 2020 14:18
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 32 Code Smells

92.3% 92.3% Coverage
1.8% 1.8% Duplication

@michalbali256 michalbali256 changed the title refactor: Conditional assembly expressions fix: Conditional assembly expressions Aug 24, 2020
@michalbali256 michalbali256 merged commit 99c45ee into development Aug 24, 2020
@github-actions
Copy link

🎉 This PR is included in version 0.12.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 0.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@michalbali256 michalbali256 deleted the ca-expr-rewrite branch February 5, 2021 10:08
SWETAS04 pushed a commit to SWETAS04/che-che4z-lsp-for-hlasm that referenced this pull request Feb 17, 2021
Co-authored-by: Zeibura Kathau <zeibura.kathau@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ANLTR visitors from the code
4 participants