Code

fix: False positives#86

Code

Merged

asmelko merged 205 commits intodevelopmenteclipse-che4z/che-che4z-lsp-for-hlasm:developmentfrom diagnostics-suppresseclipse-che4z/che-che4z-lsp-for-hlasm:diagnostics-suppressCopy head branch name to clipboardOct 15, 2020

+878-403

Commits

Commits on Apr 14, 2020

• add arithmetic expression tests

  asmelko

  committed
  fc2f434

Commits on Apr 21, 2020

• fix unary op prio in ca epxr

  asmelko

  committed
  779ec5c

• add logical expression tests

  asmelko

  committed
  6c3d7fe

Commits on May 4, 2020

• add character expresssions test

  asmelko

  committed
  54c508b

Commits on May 5, 2020

• add base ca expr architecture

  asmelko

  committed
  e74baf4

Commits on May 11, 2020

• add separate semantic variable symbol class

  asmelko

  committed
  225401a

• separate concatenation and concatenation terms

  asmelko

  committed
  0b884fe

• renaming concatenation structures

  asmelko

  committed
  66cf494

• separate variable symbol from var_sym struct

  asmelko

  committed
  d5d7ddc

• fig bug missing clear chain in collector

  asmelko

  committed
  df79af0

Commits on May 14, 2020

• add yet not defined attribute ref retrieval

  Show description for 29ec582
  asmelko

  committed
  29ec582

Commits on May 18, 2020

• add diagnosable to ca_expr

  asmelko

  committed
  17d0a01

• add expr_list resolution

  asmelko

  committed
  faa867a

• add specialized ca operator classes

  asmelko

  committed
  19af3b8

• implemented ca expr policy

  asmelko

  committed
  a3f81d8

Commits on May 20, 2020

• add generic method for resolving expression tree

  asmelko

  committed
  c728320

• finish resolve expr tree method

  asmelko

  committed
  210d2ab

Commits on May 21, 2020

• split ca_operator to unary and binary

  asmelko

  committed
  497b15a

• added specialized ca operators

  asmelko

  committed
  25b5b1c

• add generic ca expr evaluate

  asmelko

  committed
  b1e14af

• remove semantics/operand include from highlighting_info

  asmelko

  committed
  297b5a4

• add impl to unary operator evaluate

  asmelko

  committed
  ca13614

• add evaluate impl to basic binary ca exprs

  asmelko

  committed
  23779b0

Commits on May 22, 2020

• binary start impl

  asmelko

  committed
  44bc1d5

Commits on Jun 1, 2020

• add bin op evaluate

  asmelko

  committed
  c7a1960

• add evaluate impl to string, vs, constant, symbol

  asmelko

  committed
  c5cef7c

Commits on Jun 2, 2020

• add diagnosable_ctx to evaluation_context

  asmelko

  committed
  bf8265c

• moved unary functions to separate methods

  asmelko

  committed
  e935277

• move FIND and INDEX to separate methods

  asmelko

  committed
  9492694

Commits on Jun 3, 2020

• add impl of HLASM SET functions (DCVAL, X2A, ...)

  asmelko

  committed
  32b2506

Commits on Jun 4, 2020

• ca_term to separate class files

  asmelko

  committed
  10c3a5a

• add overflow checks for ca exprs

  asmelko

  committed
  2288fe5

• add dupl factor evaluation for fucntion terms

  asmelko

  committed
  2affa55

Commits on Jun 5, 2020

• add evaluate to var sym and concat chain

  asmelko

  committed
  ed5458d

Commits on Jun 8, 2020

• add imp to ca_symbol_attributes

  asmelko

  committed
  845c923

• get rid of default arg in count and number methods of variable symbols

  asmelko

  committed
  9d04856

• changed signature of try_get_symbol_name method in context manager

  asmelko

  committed
  95e3f8d

• change signature of variable symbol value retrieval methods in context manager

  asmelko

  committed
  9a46b38

• add destructor to context manager to automatically collect diags

  asmelko

  committed
  d9dc42c

Commits on Jun 9, 2020

• change signature of ca function methods to implement evaluation of self def terms

  asmelko

  committed
  909ba4e

• add ca_expr to variable symbol instead of antlr tree

  asmelko

  committed
  0eb53fe

Commits on Jun 11, 2020

• refactor out parserrulecontext pointers

  asmelko

  committed
  4da2f55

Commits on Jun 12, 2020

• refactor rules according to the new ca_expressions

  asmelko

  committed
  e0e2fc4

• parser calls resolve_expression_tree on created expressions

  asmelko

  committed
  2d40177

• rewrite tests

  asmelko

  committed
  4e04475

Commits on Jul 7, 2020

• fixes

  asmelko

  committed
  f5fca0b

• refactor type conversions

  asmelko

  committed
  e75a742

• add default type to default set_t constructor

  asmelko

  committed
  e8d5253

• change signature of dependency solver method

  asmelko

  committed
  b55d784

• refactor get_attribute_value_ca

  asmelko

  committed
  b6c853b

• fixes

  asmelko

  committed
  41fed6e

Commits on Jul 8, 2020

• add forgotten expr_kind to var_sym

  asmelko

  committed
  99c5295

• add add_diagnostic(diagnostic_s) to diagnostic_ctx, fixes

  asmelko

  committed
  ee8c5c6

• fix self def term parsing

  asmelko

  committed
  83a06a0

• add handling for terms with no separator, e.g. ((2)EQ(3))

  asmelko

  committed
  2ffb44d

• hide arithmetic limits test

  asmelko

  committed
  6496645

• master merge

  asmelko

  committed
  7c4fc9c

• reset parsing structures instead of append

  asmelko

  committed
  9603e87

Commits on Jul 9, 2020

• remove old visitors

  asmelko

  committed
  a6c27e6

• merge development

  asmelko

  committed
  1f6efde

• add ca_function tests

  asmelko

  committed
  52f5a95

• add fixes, remove expression_test from parser test

  asmelko

  committed
  aa064f3

Commits on Jul 10, 2020

• add tests for ca operations, fixes

  asmelko

  committed
  3fe8f77

• remove warnings

  asmelko

  committed
  dd2a951

• remove warnings wsl

  asmelko

  committed
  d4a8395

• apply format

  asmelko

  committed
  632013d

• merge development

  asmelko

  committed
  c9908f9

• apply format

  asmelko

  committed
  13910d4

• merge development

  asmelko

  committed
  303850e

• apply format

  asmelko

  committed
  fa69ed0

• add clear chain to model op

  asmelko

  committed
  42be4f0

Commits on Jul 13, 2020

• fix bugs

  asmelko

  committed
  cb95d82

• fix code smells

  asmelko

  committed
  ff184ed

• remove duplicities

  asmelko

  committed
  8eb90bf

• fix

  asmelko

  committed
  ccb5a11

• apply format

  asmelko

  committed
  8d63251

Commits on Jul 14, 2020

• add tests

  asmelko

  committed
  7bfa216

• apply format

  asmelko

  committed
  821a7df

• change docs, add drawio diagrams to the svg files

  asmelko

  committed
  4ac11fa

• remove code smells

  asmelko

  committed
  a164f53

• make operation method of some ca_binary_ops const

  asmelko

  committed
  ea62b75

• add lexing::token_stream field to parser_impl

  asmelko

  committed
  045328b

• made operator() in ranged_diag_collector non const

  asmelko

  committed
  bc996dc

• remove context_manager destructor

  asmelko

  committed
  f95ba23

• clang fixes

  asmelko

  committed
  c9f1f28

Commits on Jul 15, 2020

• apply format

  asmelko

  committed
  fe8d72a

• change signature of evaluate method in ca_expression

  asmelko

  committed
  8dc9d99

• remove code smells

  asmelko

  committed
  2aeed99

• add comments

  asmelko

  committed
  a084209

• add fix

  asmelko

  committed
  8c2ae39

• change grammar rules from recursive to asterisk notation

  asmelko

  committed
  2732350

Commits on Jul 17, 2020

• code scope holds macrodef in case of overriding macro definition inside of the definintion

  asmelko

  committed
  8db4615

• fix bad ATTR token creation

  asmelko

  committed
  54462a3

• added default value to symbols that can not be defined due to the unknown or undefined parameter

  asmelko

  committed
  a7032e5

Commits on Jul 20, 2020

• repair SYSNDX variable

  asmelko

  committed
  b1abcab

Commits on Jul 21, 2020

• fix test

  asmelko

  committed
  f723e2a

Commits on Jul 24, 2020

• fix

  asmelko

  committed
  03ce9fb

Commits on Jul 27, 2020

• fix bad variable type causing infinite loop

  asmelko

  committed
  aa4203c

• equ rework

  asmelko

  committed
  50f337b

Commits on Jul 29, 2020

• moved resolving of loctr deps at the end of the processing

  asmelko

  committed
  19d5bf6

• fix switching to bad loctr when resolving unknown loctr dependency

  asmelko

  committed
  f76066f

Commits on Jul 30, 2020

• change address space resolution

  asmelko

  committed
  df4475b

• fix bad adding of addresses

  asmelko

  committed
  09dea24

Commits on Jul 31, 2020

• refactored loctr depenency resolving

  asmelko

  committed
  0997357

• Merge branch 'ord-deps-refactor-work' into ord-deps-refactor

  asmelko

  committed
  d110167

• fix missed merge

  asmelko

  committed
  81c09ad

• Merge branch 'ord-deps-refactor' into space-rework

  asmelko

  committed
  51b6a9f

• refactor normalize method in address class

  asmelko

  committed
  b36c2f1

Commits on Aug 3, 2020

• add tests

  asmelko

  committed
  772df80

• clear concat chain in variable symbol

  asmelko

  committed
  aac2da6

• check for empty expressions in parser_impl::resolve_expresssion

  asmelko

  committed
  99e8050

Commits on Aug 5, 2020

• add break from resolve loop as the body changes the looped object

  asmelko

  committed
  004ecd1

Commits on Aug 6, 2020

• change is_space method in lexer to prevent infinite loops

  asmelko

  committed
  4146676

Commits on Aug 7, 2020

• fix bug in dependency collector when dividing from space

  asmelko

  committed
  8e412e0

Commits on Aug 10, 2020

• commented out warning diagnostic for substring beyond end

  asmelko

  committed
  e82c5e1

• comment out test

  asmelko

  committed
  815b058

• fixed building of mach string to produce single & when written double

  asmelko

  committed
  1fb0d69

• fix address::in_same_loctr method, add tests

  asmelko

  committed
  450d13c

Commits on Aug 11, 2020

• add missing file to some diagnostics in parser_impl.cpp

  asmelko

  committed
  0aff859

Commits on Aug 12, 2020

• fix lexer issue that falsely created ATTR token in macro operand

  asmelko

  committed
  657036d

• change undefined keyword parameter in macro call diagnostic severity to warning

  asmelko

  committed
  3ebb886

Commits on Aug 13, 2020

• fix grammar to allow spaces in single operand of a functional ca operator

  asmelko

  committed
  8dfc926

• fix bug when assembler instruction improperly evaluates its operand as an ordinary symbol

  asmelko

  committed
  2c52a64

Commits on Aug 14, 2020

• fix format of some instructions from signed to unsigned immediate value

  asmelko

  committed
  891b811

• Apply suggestions from code review

  Show description for 7ff5344
  

  asmelko

  and

  michalbali256

  authored
  7ff5344

• changed message of substring diag,

  Show description for 46fb787
  asmelko

  committed
  46fb787

• change message in ce004

  asmelko

  committed
  610f699

• add comments for ca_epxr_list and ca_expr_policy

  asmelko

  committed
  c7a8454

• Merge branch 'ca-expr-rewrite' of https://github.com/eclipse/che-che4z-lsp-for-hlasm into ca-expr-rewrite

  asmelko

  committed
  2452115

• apply format

  asmelko

  committed
  161210e

• rename and move src/checking/ranged_diagnostic_collector to src/diagnostic_adder

  asmelko

  committed
  7281fe9

• add comments

  asmelko

  committed
  da01b4c

• add tests for diagnostics and asserts that check diagnostic codes

  asmelko

  committed
  6e0182f

Commits on Aug 17, 2020

• add tests for ca_expr list

  asmelko

  committed
  c4bf817

• apply format

  asmelko

  committed
  cacd5d8

• add comments

  asmelko

  committed
  9e6db23

• add fixes and test when expression is not complete

  asmelko

  committed
  7614f5d

Commits on Aug 18, 2020

• extracted process_instruction() method from grammar rules

  asmelko

  committed
  1af31f9

Commits on Aug 19, 2020

• implement evaluable_operand virtual method for expr_assembler_operand and expr_machine_operand to suppress warning

  asmelko

  committed
  8c51468

• apply format

  asmelko

  committed
  e5d0d86

• Update Expressions.md

  zeibura

  authored
  13ad8f3

Commits on Aug 20, 2020

• separate process_statement() from parse_rest rules

  asmelko

  committed
  518a96c

Commits on Aug 26, 2020

• separate process_statement method from parse_rest parser and reparser

  asmelko

  committed
  47101eb

• separate process_ methods from lookahead rules, removed redundant parser_impl methods

  asmelko

  committed
  b82432f

Commits on Aug 27, 2020

• Merge branch 'ca-expr-rewrite' into attr-lookahead-refactor

  asmelko

  committed
  afc1dc6

Commits on Aug 28, 2020

• removed unnecessary push_line_end method from opencode provider

  asmelko

  committed
  3ea5aaa

• refactor process_next in copy and macro statement provider

  asmelko

  committed
  0f67232

• rename common_statement provider to members_statement_provider

  asmelko

  committed
  5aaa1d3

• refactored process_next in members_provider to easily trigger attr lookup

  asmelko

  committed
  48b97b5

Commits on Aug 31, 2020

• add support for attribute lookahead in all statement providers; add empty implementation of lookahead

  asmelko

  committed
  2c88a51

Commits on Sep 1, 2020

• changed signature of get_undefined_attributed_symbols method in ca_expressions; removed attribute_provider

  asmelko

  committed
  921f3ed

• change signature and implement statement_provider::try_trigger_attribute_lookahead(instruction_si)

  asmelko

  committed
  4cc10e5

• refactored processing manager and lookahead_processor to provide attribute lookahead functionality

  asmelko

  committed
  c21eb15

Commits on Sep 2, 2020

• add abstract class for macro operands

  asmelko

  committed
  1d4ca6d

• implement statement_provider::try_trigger_attribute_lookahead(statement)

  asmelko

  committed
  a69bd2f

• fix tests

  asmelko

  committed
  025d324

Commits on Sep 3, 2020

• fix bug with improperly created shared pointers in members_statement_provider

  asmelko

  committed
  60294cc

• implement optimization for lookahead

  asmelko

  committed
  e68d8f3

• add method to create start and end statement snapshot

  asmelko

  committed
  fabc6b1

Commits on Sep 4, 2020

• add functionality to extract first term from substituted machine expression in variable symbol attribute lookahead; add tests

  asmelko

  committed
  7dd1bd9

• apply format

  asmelko

  committed
  aacb482

• Merge branch 'development' into ca-expr-rewrite

  asmelko

  committed
  cce3cb0

• Merge branch 'ca-expr-rewrite' into attr-lookahead-refactor

  asmelko

  committed
  26d19e1

• fix server test error

  asmelko

  committed
  1791d2c

• remove code smells

  asmelko

  committed
  52f453e

• apply format

  asmelko

  committed
  5e3fa6f

• apply format

  asmelko

  committed
  52c51b0

Commits on Sep 7, 2020

• add JC instruction, a mnemonic alternative for BRC

  asmelko

  committed
  de9a031

• apply format

  asmelko

  committed
  340aca9

• resolve comment suggestions

  asmelko

  committed
  7ed231f

• refactor try_get_symbol_name method in context_manager

  asmelko

  committed
  cbc7ee6

Commits on Sep 8, 2020

• add test for access_operand methods

  asmelko

  committed
  5c2d01e

• remove unused method

  asmelko

  committed
  b36e69e

• Merge remote-tracking branch 'origin/development' into attr-lookahead-refactor

  asmelko

  committed
  04df73b

Commits on Sep 9, 2020

• add tests

  asmelko

  committed
  e9ba18f

Commits on Sep 10, 2020

• Merge remote-tracking branch 'origin/development' into attr-lookahead-refactor

  asmelko

  committed
  b3d8172

Commits on Sep 11, 2020

• fix bugs

  asmelko

  committed
  5bc9207

• Merge remote-tracking branch 'origin/development' into ca-expr-rewrite

  asmelko

  committed
  5feefe2

• merge development

  asmelko

  committed
  0209ff2

• merge attribute lookahead refactor

  asmelko

  committed
  fa6a089

• merge

  asmelko

  committed
  16244b4

Commits on Sep 14, 2020

• fix try_extract_leading_symbol method to support using prefixes

  asmelko

  committed
  fe343d8

• change size of length operand in MVZ instr

  asmelko

  committed
  2d1ba17

• refactor ordinary_assembly_context::add_symbol_reference method

  asmelko

  committed
  e5f509b

• Merge branch 'attr-lookahead-refactor' into diagnostics-suppress

  asmelko

  committed
  67616d3

• fix syntax error when attribute character and apostrophe are separated by continuation

  asmelko

  committed
  33fe29a

Commits on Sep 15, 2020

• change format of second operand of NIHF NILF IIHF IILF from 32b_U to 32b_S

  asmelko

  committed
  406ebe9

• merge development

  asmelko

  committed
  0e3b12f

• fix code smells

  asmelko

  committed
  6eda209

Commits on Sep 16, 2020

• add tests

  asmelko

  committed
  faf9141

• add falsely deleted instuction, removed redundant address::offset method, changed signature of helper clear_chain method in varialbe_symbol.cpp

  asmelko

  committed
  a96ae9b

Commits on Oct 2, 2020

• add missing lookahead rule

  asmelko

  committed
  ebee2ae

Commits on Oct 7, 2020

• debug

  asmelko

  committed
  d99f51e

• Revert "debug"

  Show description for ac9174a
  asmelko

  committed
  ac9174a

Commits on Oct 8, 2020

• fix bug in fuzzer

  asmelko

  committed
  44d1e66

• add comments to location_counter methods

  asmelko

  committed
  f74305c

• remove code smells

  asmelko

  committed
  edfe69e

• add tests

  asmelko

  committed
  55b848c

• Merge branch 'diagnostics-suppress' of https://github.com/eclipse/che-che4z-lsp-for-hlasm into diagnostics-suppress

  asmelko

  committed
  cbe07e3

Commits on Oct 9, 2020

• add default to return values of expression grammar rules

  asmelko

  committed
  41a071b

• add clear_concat_chain call to grammar rules that return concat_chain

  asmelko

  committed
  48cfb31

• add tests; add missing clear_concat_chain call

  asmelko

  committed
  feb54c4

• add test; add missing clear_concat_chain call

  asmelko

  committed
  d03a32e

• rewrite rule

  asmelko

  committed
  fbf8aef

• code smells

  asmelko

  committed
  a4d8e3a