-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUID byte ordering swapped #968
Comments
reicheratwork
added a commit
to reicheratwork/cyclonedds
that referenced
this issue
Sep 29, 2021
- Add byte swap to participant guid prefix Signed-off-by: Martijn Reicher <martijn.reicher@adlinktech.com>
reicheratwork
added a commit
to reicheratwork/cyclonedds
that referenced
this issue
Sep 29, 2021
- This fixes eclipse-cyclonedds#968 - Add a byte swap to the participant GUID prefix Signed-off-by: Martijn Reicher <martijn.reicher@adlinktech.com>
Merged
eboasson
pushed a commit
that referenced
this issue
Oct 2, 2021
- This fixes #968 - Add a byte swap to the participant GUID prefix Signed-off-by: Martijn Reicher <martijn.reicher@adlinktech.com>
eboasson
pushed a commit
to eboasson/cyclonedds
that referenced
this issue
Oct 7, 2021
- This fixes eclipse-cyclonedds#968 - Add a byte swap to the participant GUID prefix Signed-off-by: Martijn Reicher <martijn.reicher@adlinktech.com>
eboasson
pushed a commit
that referenced
this issue
Oct 8, 2021
- This fixes #968 - Add a byte swap to the participant GUID prefix Signed-off-by: Martijn Reicher <martijn.reicher@adlinktech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the initialization of the ddsi_guid_prefix in the rtps_init function, the ordering of the bytes in the GUID does not follow that of the specification (e.g. the vendor ID should be first two bytes).
This is due to the different manners of addressing the bytes, in 4 byte units (as the union branch u) or as 1 byte units (as the union branch s), which causes an implicit byte swap being done.
The GUID should have the vendor ID (which for cyclonedds should be 0x01, 0x10) as the bytes 1/16 and 2/16, and 13-15/16 should be a counter of the lokal entities created.
E.g.: one of the GUIDs retrieved from a builtin topic
2d 61 10 01 9a 27 b5 b0 26 43 4d 2f 00 00 01 02
Looking at this, it seems that the bytes for the vendor id are swapped and at the 3rd and 4th bytes.
The text was updated successfully, but these errors were encountered: