Remove incorrect assert in serdata_pserop_fix #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is incorrect to assert that payload should be at least 16 bytes large in for the "pserop" sertype. That condition is only valid if the topic is keyed, because it only supports keys that are exactly 16 bytes large. Instead, for an unkeyed topic, anything size is plausible and it is the deserializer that rejects malformed input. This commit also adds some tests for some variations on the participant message data theme, including one that triggers the assertion. in addition there is a bit of additional checking in constructing a new sertype_pserop. Signed-off-by: Erik Boasson <eb@ilities.com>
dpotman
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is incorrect to assert that payload should be at least 16 bytes large in for the "pserop" sertype. That condition is only valid if the topic is keyed, because it only supports keys that are exactly 16 bytes large.
Instead, for an unkeyed topic, anything size is plausible and it is the deserializer that rejects malformed input.
This commit also adds some tests for some variations on the participant message data theme, including one that triggers the assertion. in addition there is a bit of additional checking in constructing a new sertype_pserop.
Fixes #1771