Write-like operations: consistent check of data/timestamp #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some functions, notable dds_write_ts rejected negative time stamps, a choice that I think is reasonable. Unregister and dispose did not always check, but those occur necessarily after a write, and therefore allowing negative time stamps if they are rejected by a write operation makes no sense. So adding a check here is a bug fix. All write-like functions taking a data argument check for a null pointer before anything else. dds_writedispose_ts failed to do this, which then results in a different error code. That bug is also fixed here. Signed-off-by: Erik Boasson <eb@ilities.com>
dpotman
approved these changes
Nov 30, 2023
| dds_return_t ret; | ||
|
|
||
| DDSRT_WARNING_MSVC_OFF(6387); /* Disable SAL warning on intentional misuse of the API */ |
There was a problem hiding this comment.
Just a nitpick: I think these (this one and below) disable-warnings can be removed.
There was a problem hiding this comment.
Indeed. I think there are several more of those, I'll do that in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some functions, notable dds_write_ts rejected negative time stamps, a choice that I think is reasonable.
Unregister and dispose did not always check, but those occur necessarily after a write, and therefore allowing negative time stamps if they are rejected by a write operation makes no sense. So adding a check here is a bug fix.
All write-like functions taking a data argument check for a null pointer before anything else. dds_writedispose_ts failed to do this, which then results in a different error code. That bug is also fixed here.