Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump ns and context to v1 #131

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Dec 16, 2024

WHAT

bump ns and context to v1

Closes #130

@wolf4ood wolf4ood marked this pull request as ready for review December 16, 2024 10:59
@arnoweiss
Copy link
Contributor

If we merge this as-is, the redirects will point to a 0.8 URL that will serve 1.0 files. This isn't ideal but we'll have to adjust the redirects anyway due to #123. I'll open another ticket for this.

@wolf4ood
Copy link
Contributor Author

Oh i actually forgot to change the deploy stuff, we need to do change it before merge it.
I will then proceed to change the perma id with the v1 redirect. is that ok?

@arnoweiss
Copy link
Contributor

arnoweiss commented Dec 16, 2024

If we merge now, the 0.8 files aren't going to resolve at all, I think. I'm working on a PR that publishes spec text and artifacts for all releases (0.8.0, 0.8.1, HEAD). The path pattern will be:

  • https://eclipse-dataspace-dcp.github.io/decentralized-claims-protocol/releases/HEAD/resources/
  • https://eclipse-dataspace-dcp.github.io/decentralized-claims-protocol/releases/0.8.0/resources/
  • https://eclipse-dataspace-dcp.github.io/decentralized-claims-protocol/releases/0.8.1/resources/

currently it's hard-coded as resources/0.8. If you wanna prepare a PR for that on w3id, that's fine.

I think a short timeframe of non-resolution is inevitable as this, my subsequent PR and the redirects will not be merged in sync.

edit: idea scrapped as requested differently in #123

@jimmarino
Copy link
Contributor

@arnoweiss can you handle the merging of this PR and the others you refer to when you are ready?

@wolf4ood
Copy link
Contributor Author

I think it's fine though the artifacts were not there for 0.8 release and they basically refer to the 1.0 version right?

@arnoweiss arnoweiss merged commit 561f832 into eclipse-dataspace-dcp:main Dec 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump context and namespace URI to v1
3 participants