Fixed form editor not setting dirty state on delete, dialogs and cont…

…ext menus now return focus, removed navigation from schema editor
eclipse-dirigible · Jan 26, 2025 · 9141f70 · 9141f70
1 parent cefbf64
commit 9141f70
Show file tree

Hide file tree

Showing 6 changed files with 29 additions and 4 deletions.
diff --git a/...editor-form-builder/src/main/resources/META-INF/dirigible/editor-form-builder/editor.html b/...editor-form-builder/src/main/resources/META-INF/dirigible/editor-form-builder/editor.html
@@ -176,6 +176,9 @@ <h4 bk-panel-title>
                         </tr>
                     </thead>
                     <tbody bk-table-body>
+                        <tr ng-if="formData.feeds.length === 0" bk-table-row>
+                            <td bk-table-cell no-data="true">No feeds.</td>
+                        </tr>
                         <tr bk-table-row hoverable="false" ng-repeat="feed in formData.feeds track by $index">
                             <td bk-table-cell>{{feed.name}}</td>
                             <td bk-table-cell>{{feed.url}}</td>
@@ -204,6 +207,9 @@ <h4 bk-panel-title>
                         </tr>
                     </thead>
                     <tbody bk-table-body>
+                        <tr ng-if="formData.scripts.length === 0" bk-table-row>
+                            <td bk-table-cell no-data="true">No scripts.</td>
+                        </tr>
                         <tr bk-table-row hoverable="false" ng-repeat="script in formData.scripts track by $index">
                             <td bk-table-cell>{{script.name}}</td>
                             <td bk-table-cell>{{script.url}}</td>

diff --git a/...ditor-form-builder/src/main/resources/META-INF/dirigible/editor-form-builder/js/editor.js b/...ditor-form-builder/src/main/resources/META-INF/dirigible/editor-form-builder/js/editor.js
@@ -1352,6 +1352,7 @@ editorView.controller('DesignerController', ($scope, $window, $document, $timeou
 
     $scope.deleteFeed = (index) => {
         $scope.formData.feeds.splice(index, 1);
+        $scope.fileChanged();
     };
 
     $scope.addScript = () => {
@@ -1446,6 +1447,7 @@ editorView.controller('DesignerController', ($scope, $window, $document, $timeou
 
     $scope.deleteScript = (index) => {
         $scope.formData.scripts.splice(index, 1);
+        $scope.fileChanged();
     };
 
     $scope.isFormValid = () => {

diff --git a/...atform-ide/editor-schema/src/main/resources/META-INF/dirigible/editor-schema/modeler.html b/...atform-ide/editor-schema/src/main/resources/META-INF/dirigible/editor-schema/modeler.html
@@ -47,8 +47,8 @@
             <bk-button state="transparent" glyph="sap-icon--paste" aria-label="Paste" title="Paste" ng-click="paste()"></bk-button>
             <bk-toolbar-spacer></bk-toolbar-spacer>
             <bk-button state="transparent" glyph="sap-icon--list" aria-label="Properties" title="Properties" ng-click="properties()"></bk-button>
-            <bk-toolbar-separator></bk-toolbar-separator>
-            <bk-button state="transparent" glyph="sap-icon--tree" aria-label="Navigation" title="Navigation" ng-click="navigation()"></bk-button>
+            <!-- <bk-toolbar-separator></bk-toolbar-separator>
+            <bk-button state="transparent" glyph="sap-icon--tree" aria-label="Navigation" title="Navigation" ng-click="navigation()"></bk-button> -->
             <bk-toolbar-separator></bk-toolbar-separator>
             <bk-button state="transparent" glyph="sap-icon--delete" aria-label="Delete" title="Delete" ng-click="delete()"></bk-button>
             <bk-toolbar-separator></bk-toolbar-separator>

diff --git a/...m-core/src/main/resources/META-INF/dirigible/platform-core/ui/platform/contextmenu-hub.js b/...m-core/src/main/resources/META-INF/dirigible/platform-core/ui/platform/contextmenu-hub.js
@@ -10,6 +10,8 @@
  * SPDX-License-Identifier: EPL-2.0
  */
 class ContextMenuHub extends MessageHubApi {
+    #reclaimFocus = window.frameElement ? () => window.focus() : () => { };
+
     /**
      * Definition of a menu item object.
      * @typedef {Object} MenuItem
@@ -74,6 +76,7 @@ class ContextMenuHub extends MessageHubApi {
                 topic: callbackTopic,
                 handler: (data) => {
                     this.removeMessageListener(callbackListener);
+                    this.#reclaimFocus();
                     resolve(data);
                 }
             });

diff --git a/...atform-core/src/main/resources/META-INF/dirigible/platform-core/ui/platform/dialog-hub.js b/...atform-core/src/main/resources/META-INF/dirigible/platform-core/ui/platform/dialog-hub.js
@@ -18,6 +18,8 @@ const AlertTypes = {
 };
 
 class DialogHub extends MessageHubApi {
+    #reclaimFocus = window.frameElement ? () => window.focus() : () => { };
+
     constructor(viewId) {
         super();
         this.viewId = viewId || location.pathname;
@@ -54,6 +56,7 @@ class DialogHub extends MessageHubApi {
                     topic: callbackTopic,
                     handler: (data) => {
                         this.removeMessageListener(callbackListener);
+                        this.#reclaimFocus();
                         resolve(data);
                     }
                 });
@@ -105,6 +108,7 @@ class DialogHub extends MessageHubApi {
                     topic: callbackTopic,
                     handler: (data) => {
                         this.removeMessageListener(callbackListener);
+                        this.#reclaimFocus();
                         resolve(data);
                     }
                 });
@@ -213,6 +217,7 @@ class DialogHub extends MessageHubApi {
                 topic: callbackTopic,
                 handler: (data) => {
                     this.removeMessageListener(callbackListener);
+                    this.#reclaimFocus();
                     resolve(data);
                 }
             });
@@ -247,6 +252,7 @@ class DialogHub extends MessageHubApi {
      * @param {boolean} [closeButton=true] - Should the dialog have a close button in the title bar.
      */ // @ts-ignore
     showWindow({ hasHeader = true, header, title, subheader, id, path, params, width = '95%', height = '90%', maxWidth = '1280px', maxHeight = '768px', minWidth, minHeight, callbackTopic, closeButton = true } = {}) {
+        const closeTopic = `platform.${id || 'dialog'}.window.${new Date().valueOf()}`;
         this.postMessage({
             topic: 'platform.dialog.window',
             data: {
@@ -267,7 +273,15 @@ class DialogHub extends MessageHubApi {
                 maxHeight: maxHeight,
                 minWidth: minWidth,
                 minHeight: minHeight,
-                callbackTopic: callbackTopic,
+                closeTopic: closeTopic,
+            }
+        });
+        const closeListener = this.addMessageListener({
+            topic: closeTopic,
+            handler: () => {
+                this.removeMessageListener(closeListener);
+                if (callbackTopic) this.triggerEvent(callbackTopic);
+                window.focus();
             }
         });
     }

diff --git a/.../platform-core/src/main/resources/META-INF/dirigible/platform-core/ui/platform/dialogs.js b/.../platform-core/src/main/resources/META-INF/dirigible/platform-core/ui/platform/dialogs.js
@@ -147,7 +147,7 @@ angular.module('platformDialogs', ['blimpKit', 'platformView']).directive('dialo
             } else scope.$apply(() => scope.dialogWindows.push(data));
         });
         scope.closeDialogWindow = () => {
-            if (scope.dialogWindows[0].callbackTopic) dialogHub.triggerEvent(scope.dialogWindows[0].callbackTopic);
+            dialogHub.triggerEvent(scope.dialogWindows[0].closeTopic);
             scope.dialogWindows.shift();
         };