Remove v3 APIs from API modules #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThuF
reviewed
Aug 18, 2021
Comment on lines
24
to
25
| var DIRIGIBLE_BRANDING_ICON_DEFAULT = '/services/v4/web/resources/images/favicon.png'; | ||
| var DIRIGIBLE_BRANDING_WELCOME_PAGE_DEFAULT = '/services/v4/web/ide/welcome.html'; | ||
| var DIRIGIBLE_BRANDING_ICON_DEFAULT = '../../../../services/v4/web/resources/images/favicon.png'; | ||
| var DIRIGIBLE_BRANDING_WELCOME_PAGE_DEFAULT = '../../../../services/v4/web/ide/welcome.html'; |
There was a problem hiding this comment.
@nedelcho-delchev-tues could you update the ide/ui/ide-branding/src/main/resources/META-INF/dirigible/ide-branding/api/branding.js here, so that there are no relative paths:
'../../../../services/v4/web/resources/images/favicon.png'->'/services/v4/web/resources/images/favicon.png''../../../../services/v4/web/ide/welcome.html'->'/services/v4/web/ide/welcome.html'
ThuF
requested changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes all v3 APIs from the api modules
What issues does this PR fix or reference?
fixes #1055