Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial openchakra integration #2974

Merged
merged 1 commit into from
Nov 16, 2023
Merged

feat: initial openchakra integration #2974

merged 1 commit into from
Nov 16, 2023

Conversation

vmutafov
Copy link
Contributor

No description provided.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link
Contributor

@ThuF ThuF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Seems good to me.

@ThuF
Copy link
Contributor

ThuF commented Nov 15, 2023

Overview

Steps to test the openchakra integration:

  • React UI project have to be generated from the Welcome view.

    • Note: Set the file name to app.
  • Right-click on the generated template New -> UI Designer.

  • Drag & Drop some UI components.

  • Save the changes by pressing Ctrl+S/Cmd+S

  • Press the c key on the keyboard in order to open the code preview.

  • Copy the React code by pressing the Copy button.

  • Open the app.tsx file and replace the content with the React code from the UI Designer.

  • Note: By default the generated React App code is exported as a default for the module:

    import React from 'https://esm.sh/react@18.2.0'
    ...
    export default App
    • The index.tsx file needs to be updated as follows:
         import React from "https://esm.sh/react@18.2.0";
         import ReactDOM from "https://esm.sh/react-dom@18.2.0";
    -    import { App } from "./app"
    +    import App from "./app"
    
         ReactDOM.render(<App />, document.getElementById("root"));
  • After saving the changes and publishing the project, the application can be accessed by selecting the index.html.

Feedback & Findings

Some of the openchakra components are not easy to use, for example:

  • The Checkbox component can't be selected - the parent component should be selected and from the Configurations -> Children you can modify the Checkbox component.
  • The Checkbox component has isReadOnly property set by default inside the Custom props tab.
  • The Checked property of the Checkbox is not working as expected, instead a Custom property has to be set (defaultChecked=true).
  • The Radio Group is not working as expected by default - many radio buttons can be selected at the same time.
  • It seems that you can't provide Options for the Select component from the UI Designer.
  • It seems that you can't modify the text of the Tabs from the UI Designer.
  • Some more complex structures can't be created (e.g. list of links, list item can be created, but only text) - this can be workarounded by manually updating the generated code.

Sample

The following demo project can be downloaded and imported in Eclipse Dirigible: demo.zip

@delchev delchev merged commit 685a1c4 into master Nov 16, 2023
@delchev delchev deleted the vmutafov/openchakra branch November 16, 2023 15:23
StanZGenchev added a commit that referenced this pull request Nov 17, 2023
* #2982 work in progress

* Added support for folder move

* Fixed folder move and rename while files inside it are opened

* Fixed tab labels. #2982 done

* Fixed git service error messages

* Fixed 'getErrorMessage'

* Fixed 'opneView' and 'isNullOrUndefined'

* fix master formatting (#2981)

* Bump jackson.databind.version from 2.15.3 to 2.16.0

Bumps `jackson.databind.version` from 2.15.3 to 2.16.0.

Updates `com.fasterxml.jackson.core:jackson-databind` from 2.15.3 to 2.16.0
- [Commits](https://github.com/FasterXML/jackson/commits)

Updates `com.fasterxml.jackson.datatype:jackson-datatype-joda` from 2.15.3 to 2.16.0
- [Commits](FasterXML/jackson-datatype-joda@jackson-datatype-joda-2.15.3...jackson-datatype-joda-2.16.0)

Updates `com.fasterxml.jackson.datatype:jackson-datatype-jsr310` from 2.15.3 to 2.16.0

Updates `com.fasterxml.jackson.dataformat:jackson-dataformat-ion` from 2.15.3 to 2.16.0
- [Commits](https://github.com/FasterXML/jackson-dataformat-ion/commits)

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson.core:jackson-databind
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: com.fasterxml.jackson.datatype:jackson-datatype-joda
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: com.fasterxml.jackson.datatype:jackson-datatype-jsr310
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: com.fasterxml.jackson.dataformat:jackson-dataformat-ion
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump com.amazonaws:aws-java-sdk-qldb from 1.12.589 to 1.12.590

Bumps [com.amazonaws:aws-java-sdk-qldb](https://github.com/aws/aws-sdk-java) from 1.12.589 to 1.12.590.
- [Changelog](https://github.com/aws/aws-sdk-java/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-java@1.12.589...1.12.590)

---
updated-dependencies:
- dependency-name: com.amazonaws:aws-java-sdk-qldb
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump org.liquibase:liquibase-core from 4.24.0 to 4.25.0

Bumps [org.liquibase:liquibase-core](https://github.com/liquibase/liquibase) from 4.24.0 to 4.25.0.
- [Release notes](https://github.com/liquibase/liquibase/releases)
- [Changelog](https://github.com/liquibase/liquibase/blob/master/changelog.txt)
- [Commits](liquibase/liquibase@v4.24.0...v4.25.0)

---
updated-dependencies:
- dependency-name: org.liquibase:liquibase-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* feat: initial openchakra integration (#2974)

* Add messaging JavaScript API integration test (#2979)

* add messaging JavaScript API integration test

* add logs to catch the unit workflow issue

Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>

* use syserr for logging

Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>

* check File.separator

Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>

* add logging for debug

Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>

* fix display name

Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>

* fetched from master -> formatting

Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>

* fail maven build on esbuild errors

Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>

---------

Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Co-authored-by: Nedelcho Delchev <delchevn@gmail.com>

* Update pom.xml

* Fixed closing of unsaved tabs

* Bump jackson.databind.version from 2.15.3 to 2.16.0

Bumps `jackson.databind.version` from 2.15.3 to 2.16.0.

Updates `com.fasterxml.jackson.core:jackson-databind` from 2.15.3 to 2.16.0
- [Commits](https://github.com/FasterXML/jackson/commits)

Updates `com.fasterxml.jackson.datatype:jackson-datatype-joda` from 2.15.3 to 2.16.0
- [Commits](FasterXML/jackson-datatype-joda@jackson-datatype-joda-2.15.3...jackson-datatype-joda-2.16.0)

Updates `com.fasterxml.jackson.datatype:jackson-datatype-jsr310` from 2.15.3 to 2.16.0

Updates `com.fasterxml.jackson.dataformat:jackson-dataformat-ion` from 2.15.3 to 2.16.0
- [Commits](https://github.com/FasterXML/jackson-dataformat-ion/commits)

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson.core:jackson-databind
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: com.fasterxml.jackson.datatype:jackson-datatype-joda
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: com.fasterxml.jackson.datatype:jackson-datatype-jsr310
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: com.fasterxml.jackson.dataformat:jackson-dataformat-ion
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Co-authored-by: Iliyan Velichkov <velichkov.iliyan@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Vladimir Mutafov <vlado.mutafov@gmail.com>
Co-authored-by: Nedelcho Delchev <delchevn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants