Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C#] Protobuf objects in callbacks might contain old values #1593

Closed
3 tasks done
KerstinKeller opened this issue May 15, 2024 · 0 comments
Closed
3 tasks done

[C#] Protobuf objects in callbacks might contain old values #1593

KerstinKeller opened this issue May 15, 2024 · 0 comments
Assignees
@KerstinKeller
Labels
bug Something isn't working master support/v5.12 support/v5.13

Comments

@KerstinKeller
Copy link
Contributor

KerstinKeller commented May 15, 2024 •
edited
Loading

Problem Description

When you have a C# Protouf callback, the data might contain "old" values, if on the wire null values are send.

Problem could be that the object is not cleared before it's being merged from the new stream.
https://github.com/eclipse-ecal/ecal/blob/support/v5.13/lang/csharp/Continental/eCAL/Protobuf/ProtoSubscriber.cs#L86C1-L86C50

How to reproduce

Send an object with a protobuf boolean.
Set the value to true and send it. Send it again to false. In the callback it will still have the value true.

Pull Requests:
@KerstinKeller KerstinKeller self-assigned this May 15, 2024
KerstinKeller added a commit that referenced this issue May 23, 2024
@KerstinKeller
[c#] Do not reuse Protobuf message objects in callbacks, as this cann…
7a216c3 
…ot reset fields which are not contained on the wire. (#1593)
@KerstinKeller KerstinKeller mentioned this issue May 23, 2024
Merged
KerstinKeller added a commit that referenced this issue May 24, 2024
@KerstinKeller
[c#] Do not reuse Protobuf message objects in callbacks, as this cann…
419a1d1 
…ot reset fields which are not contained on the wire. (#1593) (#1610)
KerstinKeller added a commit that referenced this issue May 24, 2024
@KerstinKeller
[c#] Do not reuse Protobuf message objects in callbacks, as this cann…
865b363 
…ot reset fields which are not contained on the wire. (#1593) (#1610)
KerstinKeller added a commit that referenced this issue May 24, 2024
@KerstinKeller
[c#] Do not reuse Protobuf message objects in callbacks, as this cann…
4ef8a3a 
…ot reset fields which are not contained on the wire. (#1593) (#1610)
KerstinKeller added a commit that referenced this issue May 28, 2024
@KerstinKeller
[c#] Do not reuse Protobuf message objects in callbacks, as this cann…
6f85a3a 
…ot reset fields which are not contained on the wire. (#1593) (#1610)
KerstinKeller added a commit that referenced this issue May 28, 2024
@KerstinKeller
[c#] Do not reuse Protobuf message objects in callbacks, as this cann…
0221d4e 
…ot reset fields which are not contained on the wire. (#1593) (#1610)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KerstinKeller KerstinKeller

Labels
bug Something isn't working master support/v5.12 support/v5.13
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KerstinKeller