cleanup core folder structure #1269
Conversation
There was a problem hiding this comment.
You can specify includes in two separate ways. With "" which by convention means relative to the current file, or with <> which means relative to a specified include directory passed with -I or in cmake target_include_directories.
For portability, I'd prefer to use the <> option, and always specify relative to the include directories which we provide, which in CMake are the include directory, thus #include<ecal/ecal.h>, or relative to the source directory for private headers. #include <config/ecal_config_reader.h>.
I'd prefer not to have `#include "../header.h", as those can break more easily.
ecal/core/CMakeLists.txt
Outdated
| @@ -1,4 +1,4 @@ | |||
| # ========================= eCAL LICENSE ================================= | |||
| # ========================= eCAL LICENSE ================================= | |||
There was a problem hiding this comment.
Where does the space come from? :D
| @@ -34,7 +34,7 @@ | |||
| #endif | |||
|
|
|||
| #include "ecal_def.h" | |||
| #include "ecal_writer.h" | |||
| #include "../ecal_writer.h" | |||
There was a problem hiding this comment.
Please no relative paths in our includes. rather "readwwrite/shm/ecal_writer.h" (so every include relative to the src (or include directory)
Description
All eCAL core subfolder reorganized.
Cherry-pick to