[Core] Added missing includes #1373
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -24,7 +24,9 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include <cstddef> | |||
| #include <ecal/msg/publisher.h> | |||
There was a problem hiding this comment.
warning: 'ecal/msg/publisher.h' file not found [clang-diagnostic-error]
#include <ecal/msg/publisher.h>
^| @@ -24,7 +24,10 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include <cstddef> | |||
| #include <cstdint> | |||
| #include <ecal/msg/subscriber.h> | |||
There was a problem hiding this comment.
warning: 'ecal/msg/subscriber.h' file not found [clang-diagnostic-error]
#include <ecal/msg/subscriber.h>
^| @@ -25,8 +25,9 @@ | |||
| #pragma once | |||
|
|
|||
| #include <ecal/ecal_server.h> | |||
There was a problem hiding this comment.
warning: 'ecal/ecal_server.h' file not found [clang-diagnostic-error]
#include <ecal/ecal_server.h>
^| @@ -24,6 +24,7 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include <cstddef> | |||
| #include <ecal/ecal_deprecate.h> | |||
There was a problem hiding this comment.
warning: 'ecal/ecal_deprecate.h' file not found [clang-diagnostic-error]
#include <ecal/ecal_deprecate.h>
^| @@ -24,6 +24,7 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include <cstddef> | |||
| #include <ecal/msg/subscriber.h> | |||
There was a problem hiding this comment.
warning: 'ecal/msg/subscriber.h' file not found [clang-diagnostic-error]
#include <ecal/msg/subscriber.h>
^
ecal/core/src/ecal_util.cpp
Outdated
| #include <cstdlib> | ||
| #include <iostream> | ||
| #include <list> | ||
| #include <map> | ||
| #include <stdio.h> | ||
| #include <stdlib.h> |
There was a problem hiding this comment.
warning: inclusion of deprecated C++ header 'stdlib.h'; consider using 'cstdlib' instead [modernize-deprecated-headers]
| #include <stdlib.h> | |
| #include <cstdlib> |
| #include <memory> | ||
| #include <sstream> | ||
| #include <stdio.h> |
There was a problem hiding this comment.
warning: inclusion of deprecated C++ header 'stdio.h'; consider using 'cstdio' instead [modernize-deprecated-headers]
| #include <stdio.h> | |
| #include <cstdio> |
|
|
||
| namespace eCAL | ||
| namespace eCAL { | ||
| class CDataWriterInProc : public CDataWriterBase |
There was a problem hiding this comment.
warning: class 'CDataWriterInProc' defines a non-default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions]
class CDataWriterInProc : public CDataWriterBase
^
ecal/core/src/time/ecal_timer.cpp
Outdated
| @@ -23,10 +23,11 @@ | |||
|
|
|||
| #include <ecal/ecal.h> | |||
|
|
|||
| #include <assert.h> | |||
There was a problem hiding this comment.
warning: inclusion of deprecated C++ header 'assert.h'; consider using 'cassert' instead [modernize-deprecated-headers]
| #include <assert.h> | |
| #include <cassert> |
| @@ -17,13 +17,16 @@ | |||
| * ========================= eCAL LICENSE ================================= | |||
| */ | |||
|
|
|||
| #include <cstddef> | |||
| #include <cstdint> | |||
| #include <gtest/gtest.h> | |||
There was a problem hiding this comment.
warning: 'gtest/gtest.h' file not found [clang-diagnostic-error]
#include <gtest/gtest.h>
^
Description
Added many missing includes by Clang tidy include cleaner. I focused on STL headers and only added missing headres, but didn't remove unnecessary headers.
Cherry-pick to
master-v5 (master for eCAL 5 feature backporting)(this PR goes to that branch already)