Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Updated book theme to 1.1.2 #1455

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Conversation

FlorianReimold
Copy link
Member

@FlorianReimold FlorianReimold commented Mar 12, 2024

Description

Updated the Sphinx-book-theme

Fixes #1303

Copy link
Contributor

@KerstinKeller KerstinKeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice it looks like you're able to remove a lot of code this way 👍

Seems that this doesn't work for Ubuntu 20. 😒 due to the newer book theme not being available for that Python version...
What should we do about that? i guess the docs are build as part of the debian package generation...

@FlorianReimold
Copy link
Member Author

I mostly removed autogenerated css code that I had to modify after generation. But that's still a good thing and probably makes upgrading to future releases way easier.
But it looks like we have python 3.9 now as minimum required version. Ubuntu 20.04 by default comes with python 3.8, but as python 3.9 is installable we should be fine.

@FlorianReimold FlorianReimold merged commit 8b2bf9d into master Mar 13, 2024
13 checks passed
FlorianReimold added a commit that referenced this pull request Mar 20, 2024
Co-authored-by: Peter Günschmann<73380451+Peguen@users.noreply.github.com>
FlorianReimold added a commit that referenced this pull request Mar 20, 2024
Co-authored-by: Peter Günschmann<73380451+Peguen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update version of sphinx-book-theme
3 participants