Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implements new DataAddress validation #123

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

wolf4ood
Copy link
Contributor

What this PR changes/adds

Implements new DataAddress validation

Why it does that

fix compilation

Linked Issue(s)

Closes #122

@wolf4ood wolf4ood self-assigned this Oct 31, 2023
@wolf4ood wolf4ood added the bug_report Suspected bugs, awaiting triage label Oct 31, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (170bfe1) 80.08% compared to head (eb22f14) 64.54%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #123       +/-   ##
===========================================
- Coverage   80.08%   64.54%   -15.54%     
===========================================
  Files          19       26        +7     
  Lines         482      629      +147     
  Branches       16       28       +12     
===========================================
+ Hits          386      406       +20     
- Misses         93      218      +125     
- Partials        3        5        +2     
Files Coverage Δ
...se/edc/aws/s3/S3DataAddressValidatorExtension.java 100.00% <100.00%> (ø)
.../connector/dataplane/aws/s3/S3DataSinkFactory.java 100.00% <100.00%> (ø)
...onnector/dataplane/aws/s3/S3DataSourceFactory.java 100.00% <100.00%> (ø)
.../validation/S3DataAddressCredentialsValidator.java 91.66% <91.66%> (ø)
.../edc/aws/s3/validation/S3DataAddressValidator.java 91.66% <91.66%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wolf4ood wolf4ood added enhancement New feature or request and removed bug_report Suspected bugs, awaiting triage labels Oct 31, 2023
@wolf4ood wolf4ood force-pushed the feat/122_dataaddress_validation branch from f5f5a9f to 25ce5bb Compare October 31, 2023 09:25
@wolf4ood wolf4ood force-pushed the feat/122_dataaddress_validation branch from 25ce5bb to eb22f14 Compare October 31, 2023 09:32
@wolf4ood wolf4ood marked this pull request as ready for review October 31, 2023 11:17
Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndr-brt ndr-brt merged commit a3467c4 into eclipse-edc:main Nov 6, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorporate new DataAddress Validation
4 participants