-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests with JDK8 in GitHub actions #40
Conversation
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
time to rebase this on master and finalize... |
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
Done, but we have to wait for a new release of activation. Then I will update the pom.xml to use it, and we can merge it. |
ang-activation 2.0.0 is already in staging and integrated here, just rebase on top of master... |
It looks there is a new issue:
It seems that graal dependency was not compiled for JDK 8. |
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
pom.xml
Outdated
@@ -91,7 +91,7 @@ Copyright © 2019, ${current.year} Eclipse Foundation. All rights reserved.] | |||
<servlet-api.version>5.0.0</servlet-api.version> | |||
<angus.activation.version>2.0.0</angus.activation.version> | |||
<angus-mail.version>${project.version}</angus-mail.version> | |||
<graal.sdk.version>22.3.0</graal.sdk.version> | |||
<graal.sdk.version>22.0.0</graal.sdk.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prefer exclusion of the file from the build on JDK 8 over changing graalvm version
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adding JDK8 to make sure there are no runtime errors with JDK8.
Currently test are failing because of test errors, which is actually what we wanted:
This will work when this PR is merged and we update the version of angus-activation.
I keep this as a draft till that moment happens to keep the builds green.
You can test this following these steps: eclipse-ee4j/angus-activation#11