Proposal: Have to the ability to dynamically set the Validation Group for pre-persist during transaction

[exabrial]

One weakness of the JPA Specification is that you cannot (to my knowledge) specify a validation group to evaluate during a persist call.

Example: This does not work:

em.setProperty(PersistenceUnitProperties.VALIDATION_GROUP_PRE_PERSIST, SomeValidationGroup.class.toString());
em.persist(entity);

Looking at BeanValidationListener.java however, this seems like it'd be trivial to implement.

Existing code:

    @Override
    public void prePersist (DescriptorEvent event) {
        validateOnCallbackEvent(event, "prePersist", groupPrePersit);
    }

Proposal:

    @Override
    public void prePersist (DescriptorEvent event) {
        Class<?>[] overrideGroup = event.getSession().getParent().getProperties.get("eclipselink.validation.override.pre-persist");
        if (overrideGroup != null){
            validateOnCallbackEvent(event, "prePersist", overrideGroup);
        } else {
            validateOnCallbackEvent(event, "prePersist", groupPrePersit);
        }
    }

If we put together a patch, does anyone have any concerns about this? What we would need to submit for tests, docs, etc? We're still using 2.7.x series, but we'd try to patch all of the active development versions (what are they?)

Thank you!

[exabrial]

Anyone? :) we're still happy to work on this. Just wondering what the chances of a merge are before we do the work.

As always, thank you EclipseLink team for your hard work.

[exabrial]

Hello EclipseLink team, I just wanted to say thank you for all your work. We love EclipseLink and appreciate all the leadership on the project.

I know what we're requesting is outside the spec of JPA, and I just want to make sure that's ok. I think a lot of users would fine this quite useful. I hope to implement it in a similar vein to how MULTITENANT_PROPERTY_DEFAULT works which is also outside the JPA spec, but works quite nicely and is a very useful feature.

Thank you again