Merge pull request #23425 from hussainnm/fix-jar-signer

Failed to create signed jar for appclient
eclipse-ee4j · Mar 17, 2021 · fd979a0 · fd979a0
2 parents 83e8450 + 1c99bfe
commit fd979a0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/...core/src/main/java/org/glassfish/appclient/server/core/jws/servedcontent/ASJarSigner.java b/...core/src/main/java/org/glassfish/appclient/server/core/jws/servedcontent/ASJarSigner.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1997, 2018 Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1997, 2021 Oracle and/or its affiliates. All rights reserved.
  *
  * This program and the accompanying materials are made available under the
  * terms of the Eclipse Public License v. 2.0, which is available at
@@ -72,8 +72,8 @@ public class ASJarSigner implements PostConstruct {
     /** default alias for signing if the admin does not specify one */
     private static final String DEFAULT_ALIAS_VALUE = "s1as";
 
-    private static final String DEFAULT_DIGEST_ALGORITHM = "SHA1";
-    private static final String DEFAULT_KEY_ALGORITHM = "RSA";
+    private static final String DEFAULT_DIGEST_ALGORITHM = "SHA-1";
+    private static final String DEFAULT_SIGNATURE_ALGORITHM = "SHA1withRSA";
 
     private static final SecuritySupport securitySupport = SecuritySupport.getDefaultInstance();
 
@@ -154,7 +154,7 @@ public long signJar(final File unsignedJar, final ZipOutputStream signedJar,
 
                 JarSigner signer = new JarSigner.Builder(privateKey, certPath)
                         .digestAlgorithm(DEFAULT_DIGEST_ALGORITHM)
-                        .signatureAlgorithm(DEFAULT_KEY_ALGORITHM)
+                        .signatureAlgorithm(DEFAULT_SIGNATURE_ALGORITHM)
                         .build();
 
                 // TODO: add Attributes to Manifest and additionalContent

diff --git a/nucleus/admin/template/src/main/resources/config/server.policy b/nucleus/admin/template/src/main/resources/config/server.policy
@@ -138,3 +138,8 @@ grant codeBase "jrt:/jdk.compiler" {
       permission java.lang.RuntimePermission "getenv.JDK_JAVAC_OPTIONS";
       permission java.lang.RuntimePermission "createClassLoader";
 };
+
+// Following grant block is required for using JDK JarSigner
+grant {
+    permission java.lang.RuntimePermission "accessClassInPackage.jdk.internal.misc";
+};