Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill Descriptor.boundsChecking #24084

Open
dmatej opened this issue Aug 19, 2022 · 2 comments
Open

Kill Descriptor.boundsChecking #24084

dmatej opened this issue Aug 19, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@dmatej
Copy link
Contributor

dmatej commented Aug 19, 2022

Problem Description

  • cargo cult synchronization of it's setter and getter when affected usages are not synchronized. Any change affects all parallel deployments, but as it takes just microseconds, collisions are not happening. Maybe in the year 2030 ;)
  • effectively relies on a call of SetMethodAction, nothing else changes the value.
  • usages of isBoundsChecking are not just in setters.

Expected Changes

  • Just remove it and remove also all related code in dead branches.
  • Will throw exceptions if someone would use invalid values in descriptors elements covered by related code. Until now it would tolerate invalid values and just use defaults for some setters, see the image.
    image

Notes (may be expanded later)

  • analyze effects of removal in the getType , it switches primitive types to object types if the bounds checking is disabled.
@dmatej dmatej added the bug Something isn't working label Aug 19, 2022
dmatej added a commit to dmatej/glassfish that referenced this issue Aug 19, 2022
dmatej added a commit to dmatej/glassfish that referenced this issue Aug 22, 2022
dmatej added a commit to dmatej/glassfish that referenced this issue Aug 24, 2022
dmatej added a commit to dmatej/glassfish that referenced this issue Aug 25, 2022
dmatej added a commit to dmatej/glassfish that referenced this issue Aug 29, 2022
dmatej added a commit to dmatej/glassfish that referenced this issue Sep 7, 2022
dmatej added a commit to dmatej/glassfish that referenced this issue Sep 18, 2022
@github-actions
Copy link

This issue has been marked as inactive and old and will be closed in 7 days if there is no further activity. If you want the issue to remain open please add a comment

@github-actions github-actions bot added the Stale label Aug 20, 2023
@dmatej dmatej removed the Stale label Aug 20, 2023
Copy link

This issue has been marked as inactive and old and will be closed in 7 days if there is no further activity. If you want the issue to remain open please add a comment

@github-actions github-actions bot added the Stale label Aug 20, 2024
@dmatej dmatej removed the Stale label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant