Update jsonp version to use jakarta package #22943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
|
Can one of the admins verify this patch? |
|
https://ci.eclipse.org/glassfish/job/glassfish/job/PR-22943/1/testReport/ There are 5 tests failing in 'continuous-integration/jenkins/pr-merge' but I cannot see the reason of the failure. This is what I see: |
|
@jbescos You'd have to take a look at the full logs for the stage where failures occurred. See https://ci.eclipse.org/glassfish/job/glassfish/job/PR-22943/ ejb_group_3 has failures, and you can look at its logs to get an idea of what failed. You can also download the artefacts that the run generated and inspect the server log. |
|
I have checked the error, and it is caused by what I said before. Jersey is trying to load the previous jsonp with different package, and it doesn't find it. I copy the exception here: |
|
OK probably needs a Jersey update before we can merge |
|
@jansupol do you think it is feasible to make Jersey to use the latest jsonp libraries (having jakarta packages)?. Then I can update Glassfish in this PR to use the latest Jersey libraries. Problem could be that other libraries in Jersey also uses JSONP. In this case I would need to update them too. |
|
@smillidge We will never merge anything if this approach is used. Implementations dependency graph is too complicated and there are some cross-dependencies. We should accept that |
|
OK I put out a discussion on the mailing list RE: how to do this in parallel. I suppose that's a question to go out to the list. Can we accept a broken master as I imagine in some cases server won't start at all due to OSGI issues? |
|
OK let's break master. |
smillidge
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works to compile, execute the quick look tests, start the domain, running TCK tests of this other PR jakartaee/platform-tck#147 . Sig tests works too if you use an updated sigtest.jar
I attach some logs of previous executions.
gfQuickLook.log
tck.log
It seems that glassfish is not making use directly jsonp, and that is why previous executions worked.
But I expect to have run time errors. For example if you run an app that is using Jersey (because Jersey depends on Jsonp).
There is a discussion going on about this jakarta integration topic:
#22892 (comment)