Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#23455: javaee.jar should be renamed to jakartaee.jar #23904

Merged
merged 4 commits into from
Apr 20, 2022
Merged

#23455: javaee.jar should be renamed to jakartaee.jar #23904

merged 4 commits into from
Apr 20, 2022

Conversation

lukasj
Copy link
Member

@lukasj lukasj commented Apr 19, 2022

fixes #23455

notes:

  • I did not run tests on my end this time
  • the jar is no longer in /lib but in /modules folder - don't think it's caused by this change

@dmatej
Copy link
Contributor

dmatej commented Apr 20, 2022

cdi_all tests failed, I think they used the javaee.jar

21:51:29      [javac] Compiling 1 source file to /home/jenkins/agent/workspace/_test-using-jenkinsfile_PR-23904/appserver/tests/appserv-tests/build/module/classes
21:51:29      [javac] /home/jenkins/agent/workspace/_test-using-jenkinsfile_PR-23904/appserver/tests/appserv-tests/devtests/cdi/javaee-integration/normal-bean-injection-ear/client/com/acme/Client.java:25: error: package jakarta.annotation does not exist
21:51:29      [javac] import jakarta.annotation.Resource;
21:51:29      [javac]                          ^
21:51:29      [javac] /home/jenkins/agent/workspace/_test-using-jenkinsfile_PR-23904/appserver/tests/appserv-tests/devtests/cdi/javaee-integration/normal-bean-injection-ear/client/com/acme/Client.java:40: error: cannot find symbol
21:51:29      [javac]     @Resource(lookup = "java:app/env/value1")
21:51:29      [javac]      ^
21:51:29      [javac]   symbol:   class Resource
21:51:29      [javac]   location: class Client
21:51:29      [javac] 2 errors

lukasj added 3 commits April 20, 2022 13:15
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@lukasj
Copy link
Member Author

lukasj commented Apr 20, 2022

the jar is no longer in /lib but in /modules folder - don't think it's caused by this change

what I think and what is right can be two different things - anyway problem fixed; tests were updated to use the new file name as well

Signed-off-by: Lukas Jungmann <lukas.jungmann@oracle.com>
@dmatej dmatej merged commit 25f2bdc into eclipse-ee4j:master Apr 20, 2022
@dmatej dmatej added this to the 7.0.0 milestone Apr 20, 2022
@lukasj lukasj deleted the is23455 branch April 20, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$GF/lib/javaee.jar should be renamed to jakartaee.jar
2 participants