Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes EnterpriseBeanLifecycleTest - using GF (de)serialization #23971

Merged
merged 2 commits into from
Jun 6, 2022

Conversation

dmatej
Copy link
Contributor

@dmatej dmatej commented Jun 6, 2022

  • BeanImpl in Weld doesn't care about IndirectlySerializable classes, so this impl cares
  • it wasn't possible to override just some methods of the weld-porting-package-tck implementation, Weld then started complaining we have two implementations because it loaded both property files (?)
  • GlassFishContextImpl and GlassFishELImpl are copy-pasted from weld-porting-package-tck for now, but it is probable they will change soon too.

Signed-off-by: David Matějček dmatej@seznam.cz

- BeanImpl in Weld doesn't care about IndirectlySerializable classes, so this
  impl cares
- it wasn't possible to override just some methods of the weld-porting-package-tck
  implementation, Weld then started complaining we have two implementations
  because it loaded both property files (?)
- GlassFishContextImpl and GlassFishELImpl are copy-pasted from weld-porting-package-tck
  for now, but it is probable they will change soon too.


Signed-off-by: David Matějček <dmatej@seznam.cz>
@dmatej dmatej requested a review from arjantijms June 6, 2022 20:11
Signed-off-by: David Matějček <dmatej@seznam.cz>
@dmatej
Copy link
Contributor Author

dmatej commented Jun 6, 2022

Local testing: with 4.0.3 CDI TCK there is yet 13 failing tests; this morning it was 19.

@dmatej dmatej added this to the 7.0.0 milestone Jun 6, 2022
@dmatej dmatej linked an issue Jun 6, 2022 that may be closed by this pull request
11 tasks
Copy link
Contributor

@arjantijms arjantijms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w00t!

@arjantijms arjantijms merged commit 0c63273 into eclipse-ee4j:master Jun 6, 2022
@dmatej dmatej deleted the cdi branch June 7, 2022 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDI Test failures with GlassFish 7
2 participants