Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Nimbus 9.28 #24230

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Integrate Nimbus 9.28 #24230

merged 1 commit into from
Jan 10, 2023

Conversation

arjantijms
Copy link
Contributor

Signed-off-by: Arjan Tijms arjan.tijms@omnifish.ee

Signed-off-by: Arjan Tijms <arjan.tijms@omnifish.ee>
@arjantijms arjantijms added the component upgrade A component dependency has been upgraded label Jan 9, 2023
@arjantijms arjantijms added this to the 7.0.1 milestone Jan 9, 2023
@arjantijms arjantijms self-assigned this Jan 9, 2023
@pzygielo
Copy link
Contributor

pzygielo commented Jan 9, 2023

I suppose, that the failure

[2023-01-09T20:33:04.646Z] [ERROR]   LoggingRestITest.logFileNames:54 » JSON A JSONObject text must begin with '{' at character 1 of "{\"InstanceLogFileNames\": [\"server.log\"]}\n"
[2023-01-09T20:28:34.370Z] [ERROR] org.glassfish.main.admin.test.rest.LoggingRestITest.viewLogDetails  Time elapsed: 0.124 s  <<< ERROR!
[2023-01-09T20:28:34.372Z] org.codehaus.jettison.json.JSONException: A JSONObject text must begin with '{' at character 1 of "{\"records\": [{\"recordNumber\":47,\"loggedDa
...

is somehow connected with

but I haven't investigated that in detail yet.
The jettison issue mentions Windows to be involved, but I think just CentOS is used in GF pipeline.

@arjantijms
Copy link
Contributor Author

It did pass in the last two attempts, for some reason or the other.

@arjantijms arjantijms merged commit 772287f into eclipse-ee4j:master Jan 10, 2023
@arjantijms arjantijms deleted the nimbus928 branch January 10, 2023 08:28
@dmatej
Copy link
Contributor

dmatej commented Jan 10, 2023

I know about this, it happens from time to time, but even when I tried to copy the JSON data to some public validator, it passed. I would buy a beer to someone who would be able to create a reliable reproducer and fix it.
I have seen it on Jenkins with Ubuntu, Jenkins with CentOS, and even locally on Kubuntu.
@pzygielo Yeah, that's exactly the issue :-)
(note about the validation - I used copy and paste to a web form, so CRLF were automatically resolved)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component upgrade A component dependency has been upgraded
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants