Unpack glassfish-jar type for embedded-web #24275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding glassfish-jul-extension dependency in PR #24270 did not fix the ClassNotFoundException in embedded-web. The unpack-jar-dependencies did not add the org.glassfish.main.jul package into the jar. This fix adds glassfish-jar type to the includeTypes list in the unpack-jar-dependencies goal. |
Same change as 87a7d54 done for embedded-all Signed-off-by: hussainnm <hussain.nm@cognizant.com>
hussainnm
force-pushed
the
embedded-deps
branch
from
719489e to
fdaa200
Compare
arjantijms
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same change as 87a7d54 done for embedded-all