Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classes in ScatteredArchive are processed only once. #24570

Conversation

OndroMih
Copy link
Contributor

@OndroMih OndroMih commented Sep 3, 2023

They are not processed again when the parser is called for JARs (web fragments). Signed-off-by:Ondro Mihalyi

Fixes #24415.

To do:

They are not processed again when the parser is called for JARs (web fragments).
Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
@OndroMih
Copy link
Contributor Author

OndroMih commented Sep 8, 2023

Added test. Now looking at what to do with the WebFragmentDescriptor.

@OndroMih
Copy link
Contributor Author

I won't have time to fix the WebFragmentDescriptor part any time soon. Since nobody reported any issue with it, I won't fix it in this PR. Instead, I've created a separate issue for it: #24592.

This PR is now ready to be reviewed and merged.

@OndroMih OndroMih marked this pull request as ready for review September 18, 2023 20:26
@OndroMih
Copy link
Contributor Author

@dmatej , @avpinchuk , @ctabin , please review.

Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
@arjantijms arjantijms added this to the 7.0.9 milestone Sep 19, 2023
@arjantijms arjantijms added the bug Something isn't working label Sep 19, 2023
@arjantijms arjantijms merged commit 7f8e752 into eclipse-ee4j:master Sep 19, 2023
@OndroMih OndroMih deleted the ondromih-fix-24415-contextInitialized-multiple-times-in-embedded branch October 29, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[7.0.4] ServletContextListener.contextInitialized invoked multiple times
3 participants