Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize servlet caching filter #24748

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

avpinchuk
Copy link
Contributor

@avpinchuk avpinchuk commented Jan 16, 2024

Eliminates possible unnecessary multiple loads of a same resource under high request rate

Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
@avpinchuk avpinchuk added this to the 7.0.12 milestone Jan 16, 2024
@avpinchuk avpinchuk self-assigned this Jan 16, 2024
@avpinchuk avpinchuk marked this pull request as ready for review January 16, 2024 22:08
Copy link
Contributor

@hs536 hs536 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The nesting will become deeper, but it seems that with this addition, we can avoid the problem without locking the cache.

@arjantijms arjantijms merged commit 95fd390 into eclipse-ee4j:master Jan 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants