Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Admin Console loading options #24814

Merged
merged 8 commits into from
Feb 24, 2024

Conversation

avpinchuk
Copy link
Contributor

@avpinchuk avpinchuk commented Feb 15, 2024

Improve the Administration Console loading options:

  • ALWAYS loads the Console at server startup (eager loading)
  • DEFAULT loads the Console only after first access to it (on demand loading, used by default)
  • Implements NEVER loading option that disable the Admin Console.

Also cleaned up the console-related code.

Usage

Synopsis

asadmin set server.admin-service.property.adminConsoleStartup={default|always|never}

Example

This enforces Admin Console to be loaded at server startup:

asadmin set server.admin-service.property.adminConsoleStartup=always

After setting up the property the domain must be restarted to apply changes.

@avpinchuk avpinchuk force-pushed the admin-console-lifecycle branch from 95dccca to a2f3ecb Compare February 16, 2024 23:05
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
@avpinchuk avpinchuk force-pushed the admin-console-lifecycle branch from a2f3ecb to 3f006ec Compare February 17, 2024 16:40
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
@avpinchuk avpinchuk changed the title Change admin console loading conditions Improve the Admin Console loading options Feb 21, 2024
@avpinchuk avpinchuk added enhancement New feature or request code cleaning labels Feb 21, 2024
@avpinchuk avpinchuk added this to the 7.0.13 milestone Feb 21, 2024
@avpinchuk avpinchuk self-assigned this Feb 21, 2024
@avpinchuk avpinchuk marked this pull request as ready for review February 21, 2024 21:52
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
@pzygielo pzygielo marked this pull request as draft February 22, 2024 08:07
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
@pzygielo pzygielo marked this pull request as ready for review February 22, 2024 18:12
@arjantijms arjantijms merged commit 1cc22ab into eclipse-ee4j:master Feb 24, 2024
2 checks passed
@OndroMih
Copy link
Contributor

@avpinchuk, this is a nice addition. Wiuld be good to document how to use it (set the loading option via asadmin or admin console) at least here in the PR description. Ideally also in one of the GlassFish guides somewhere.

@avpinchuk
Copy link
Contributor Author

@OndroMih, I added a description to this PR.

Also I'll think about which reference guide to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleaning enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants