-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the Admin Console loading options #24814
Merged
arjantijms
merged 8 commits into
eclipse-ee4j:master
from
avpinchuk:admin-console-lifecycle
Feb 24, 2024
Merged
Improve the Admin Console loading options #24814
arjantijms
merged 8 commits into
eclipse-ee4j:master
from
avpinchuk:admin-console-lifecycle
Feb 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95dccca
to
a2f3ecb
Compare
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
a2f3ecb
to
3f006ec
Compare
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
dmatej
approved these changes
Feb 21, 2024
nucleus/core/kernel/src/main/java/com/sun/enterprise/v3/admin/adapter/AdminConsoleAdapter.java
Show resolved
Hide resolved
nucleus/core/kernel/src/main/java/com/sun/enterprise/v3/admin/adapter/InstallerThread.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
pzygielo
reviewed
Feb 22, 2024
nucleus/core/kernel/src/main/java/com/sun/enterprise/v3/admin/adapter/LocalStrings.properties
Show resolved
Hide resolved
dmatej
approved these changes
Feb 23, 2024
arjantijms
approved these changes
Feb 24, 2024
@avpinchuk, this is a nice addition. Wiuld be good to document how to use it (set the loading option via asadmin or admin console) at least here in the PR description. Ideally also in one of the GlassFish guides somewhere. |
@OndroMih, I added a description to this PR. Also I'll think about which reference guide to change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the Administration Console loading options:
Also cleaned up the console-related code.
Usage
Synopsis
Example
This enforces Admin Console to be loaded at server startup:
asadmin set server.admin-service.property.adminConsoleStartup=always
After setting up the property the domain must be restarted to apply changes.