Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrency for GlassFish 8 #24954

Merged
merged 23 commits into from
Jun 6, 2024
Merged

Concurrency for GlassFish 8 #24954

merged 23 commits into from
Jun 6, 2024

Conversation

dmatej
Copy link
Contributor

@dmatej dmatej commented May 15, 2024

Draft PR depending on work of @aubi , see eclipse-ee4j/glassfish-concurro#85

Requires also new Concurrency TCK 3.1.1:
jakartaee/concurrency#511

@dmatej dmatej added the enhancement New feature or request label May 15, 2024
@dmatej dmatej added this to the 8.0.0 milestone May 15, 2024
@aubi
Copy link

aubi commented May 31, 2024

This branch waits either for (preferably) a release of Concurro and update of the dependency or staging Concurro SNAPSHOT.

@dmatej
Copy link
Contributor Author

dmatej commented Jun 3, 2024

It waits also for #24962 as I need to rebase this branch then and remove duplicities. I already done that locally, but it is safer to merge to master first.

dmatej and others added 23 commits June 6, 2024 14:21
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
# Conflicts:
#	appserver/common/glassfish-naming/src/main/java/com/sun/enterprise/naming/impl/GlassfishNamingManagerImpl.java
#	appserver/deployment/dol/src/main/java/com/sun/enterprise/deployment/util/DOLUtils.java
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
… DOL

- Classifiers may be distributed in a library which is not accessible to the
  deployment classloader yet.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- Now follows the same pattern as other concurrency converters

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
…ition

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- Depends on elementsAllowingEmptyValue() specified by a root node, but now
  I am not sure which is the right one. That part will be committed tomorrow.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
…nvocation

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

# Conflicts:
#	appserver/web/weld-integration/src/main/java/org/glassfish/weld/WeldDeployer.java
- This fixed the last concurrency TCK test

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Use Concurro 3.1.0-M4 instead of SNAPSHOT
- With 3.1.0 several tests fail
- Required PRs were already merged to the TCK main, but we have to wait for
  the release.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej dmatej force-pushed the concurrency-gf8 branch 2 times, most recently from 804fa25 to da67edb Compare June 6, 2024 14:18
@dmatej dmatej marked this pull request as ready for review June 6, 2024 14:50
@arjantijms arjantijms merged commit 9deb129 into 8.0 Jun 6, 2024
2 checks passed
@pzygielo pzygielo deleted the concurrency-gf8 branch June 6, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants