-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concurrency for GlassFish 8 #24954
Merged
Merged
Concurrency for GlassFish 8 #24954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This branch waits either for (preferably) a release of Concurro and update of the dependency or staging Concurro SNAPSHOT. |
It waits also for #24962 as I need to rebase this branch then and remove duplicities. I already done that locally, but it is safer to merge to master first. |
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
# Conflicts: # appserver/common/glassfish-naming/src/main/java/com/sun/enterprise/naming/impl/GlassfishNamingManagerImpl.java # appserver/deployment/dol/src/main/java/com/sun/enterprise/deployment/util/DOLUtils.java
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
… DOL - Classifiers may be distributed in a library which is not accessible to the deployment classloader yet. Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
…tions" This reverts commit 2615369.
- Now follows the same pattern as other concurrency converters Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
…ition Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- Depends on elementsAllowingEmptyValue() specified by a root node, but now I am not sure which is the right one. That part will be committed tomorrow. Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
…nvocation Signed-off-by: David Matějček <david.matejcek@omnifish.ee> # Conflicts: # appserver/web/weld-integration/src/main/java/org/glassfish/weld/WeldDeployer.java
- This fixed the last concurrency TCK test Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Use Concurro 3.1.0-M4 instead of SNAPSHOT
- With 3.1.0 several tests fail - Required PRs were already merged to the TCK main, but we have to wait for the release. Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
804fa25
to
da67edb
Compare
arjantijms
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR depending on work of @aubi , see eclipse-ee4j/glassfish-concurro#85
Requires also new Concurrency TCK 3.1.1:
jakartaee/concurrency#511