Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed insecure XML processing - all XSDs and DTD have to be local #25147

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Fixed insecure XML processing - all XSDs and DTD have to be local #25147

merged 1 commit into from
Sep 17, 2024

Conversation

dmatej
Copy link
Contributor

@dmatej dmatej commented Sep 17, 2024 •
edited
Loading

Additional changes:

  • It is better to close the stream where it was open, symmetrically (try-with)

@dmatej dmatej added the bug Something isn't working label Sep 17, 2024
@dmatej dmatej added this to the 7.0.18 milestone Sep 17, 2024
@dmatej dmatej self-assigned this Sep 17, 2024
@dmatej dmatej marked this pull request as draft September 17, 2024 14:28
@dmatej
Fixed insecure XML processing - all XSDs and DTD have to be local
d015103 
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej dmatej marked this pull request as ready for review September 17, 2024 20:30
@dmatej dmatej merged commit af8ad8c into eclipse-ee4j:master Sep 17, 2024
2 checks passed
@dmatej dmatej deleted the xmlprocessing-safe branch September 17, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avpinchuk avpinchuk avpinchuk approved these changes

@arjantijms arjantijms Awaiting requested review from arjantijms

@pzygielo pzygielo Awaiting requested review from pzygielo

Assignees

@dmatej dmatej

Labels
bug Something isn't working
Projects
None yet
Milestone
7.0.18
Development

Successfully merging this pull request may close these issues.
2 participants
@dmatej @avpinchuk