Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntelliJ plugin fix: bring back the previous constructor to avoid a breaking change #25189

Merged
merged 1 commit into from
Oct 20, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,21 @@ public class RemoteResponseManager implements ResponseManager {
private final String response;
private Map<String, String> mainAtts = Collections.emptyMap();

/**
* Creates the object with the default charset by delegating to the {@link #RemoteResponseManager(java.io.InputStream, java.nio.charset.Charset, int, java.util.logging.Logger)} constructor.
* @param in
* @param code
* @param logger
* @throws RemoteException
* @throws IOException
* @deprecated It is encouraged to use the {@link #RemoteResponseManager(java.io.InputStream, java.nio.charset.Charset, int, java.util.logging.Logger)} constructor with explicit charset. This constructor is kept only for backwards compatibility with the IntelliJ Idea plugin.
*/
@Deprecated(since = "7.0.18")
public RemoteResponseManager(InputStream in, int code, Logger logger)
throws RemoteException, IOException {
this(in, Charset.defaultCharset(), code, logger);
}

public RemoteResponseManager(InputStream in, Charset charset, int code, Logger logger)
throws RemoteException, IOException {
this.code = code;
Expand Down