Fix #25216 Redirection does not work after session timeout in Admin Console #25217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add an exception handler for the Admin Console to handle jakarta.faces.application.ViewExpiredException and to redirect the page when session timeout. - For ajax requests, since forwarding/redirection methods of JSF do not work as expected, this fix uses redirection by windows.location.href as workaround. Signed-off-by: Takahiro Nagao <nagao.takahiro@fujitsu.com>
OndroMih
approved these changes
Nov 19, 2024
| if (facesContext.getPartialViewContext().isAjaxRequest()) { | ||
| facesContext.getExternalContext().getResponseOutputWriter().write( | ||
| "<script type='text/javascript'>" | ||
| + "window.location.href = '" + facesContext.getExternalContext().getRequestContextPath() + "/';" |
There was a problem hiding this comment.
This can be stored in a variable and reused on line 53.
Signed-off-by: Takahiro Nagao <nagao.takahiro@fujitsu.com>
dmatej
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25216 .
This fix adds an exception handler for the Admin Console to handle
jakarta.faces.application.ViewExpiredException.For Ajax requests, since forwarding/redirection methods of JSF do not work as expected, this fix uses redirection by
windows.location.hrefas workaround.