Fixed RarHandler - non-absolute URL to File conversion #25226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dmatej
commented
Nov 24, 2024
dmatej
commented
- As the Archive#getURI says, the method can return nearly anything and there no guarantee that the URI can be converted to a File.
- Sometimes it is an absolute file, sometimes relative path, sometimes URI pointing to a file inside jar inside ear.
- This minimal fix avoids an exception, and it is similar to conversion used on other places.
pzygielo
reviewed
Nov 24, 2024
...ectors/connectors-runtime/src/main/java/com/sun/enterprise/connectors/module/RarHandler.java
Outdated
Show resolved
Hide resolved
- As the Archive#getURI says, the method can return nearly anything and there no guarantee that the URI can be converted to a File. - Sometimes it is an absolute file, sometimes relative path, sometimes URI pointing to a file inside jar inside ear. - This minimalistic fix avoids an exception, similar is on other places. Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
dmatej
requested review from
pzygielo,
OndroMih,
arjantijms,
avpinchuk and
a team
arjantijms
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.