Fixes and cleanup around IMQ startup and shutdown #25227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing - When crashed, I had nothing useful in logs - SEVERE instead of WARN + FINE (don't ignore errors, provide all useful info) - Added FINE(ST) logs instead of swallowed exceptions (not sure how often are those exceptions). - Exception in shutdown broke the rest of shutdown - fixed - Fixed "This doesn't work in clustered instances." - resolving broker home dir. Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
…lization - No need to do that in default constructor - Default constructor is implicit after this change Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
…Buffer Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
arjantijms
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.