Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare glassfish-jul-extension test dependency #25339

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

pzygielo
Copy link
Contributor

@pzygielo pzygielo commented Jan 21, 2025

I prefer this (to have it in 15 projects) over the above (to have it everywhere).

@dmatej
Copy link
Contributor

dmatej commented Jan 22, 2025

This is bit messy ... you did not remove it from parent here, and I see another PR, what is what?
If it is a test dependency, OK, I have this preference too, especially if we do that with JUnit too.

@dmatej
Copy link
Contributor

dmatej commented Jan 22, 2025

Oh, I see ... it is in the dependency management, right?
EDIT: yes:

<dependency>
<groupId>org.glassfish.main</groupId>
<artifactId>glassfish-jul-extension</artifactId>
<version>${project.version}</version>
<!-- default scope; some modules have to set another -->
<scope>test</scope>
</dependency>

@dmatej dmatej added this to the 7.0.22 milestone Jan 22, 2025
@dmatej dmatej merged commit 375e742 into eclipse-ee4j:master Jan 22, 2025
3 checks passed
@pzygielo pzygielo deleted the ijul branch January 22, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not load Logmanager "org.glassfish.main.jul.GlassFishLogManager" in CI console
2 participants